lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Skip processing non-provided additional configs #336

Merged
justusbunsi merged 4 commits from refs/pull/336/head into master 2022-08-04 13:46:05 +00:00
Conversation 0 Commits 4 Files Changed 1 +7 -5
justusbunsi commented 2022-07-10 12:30:18 +00:00 (Migrated from gitea.com)
Copy Link

Description of the change

There is a chance that no additional configuration sources are provided. The current processing of such sources don't take this into account, leading to irritating error messages (no such file or directory). Luckily, the init container doesn't break due to this error.
This checks for the directory to exist before processing data from it.

### Description of the change There is a chance that no additional configuration sources are provided. The current processing of such sources don't take this into account, leading to irritating error messages (`no such file or directory`). Luckily, the init container doesn't break due to this error. This checks for the directory to exist before processing data from it.
luhahn (Migrated from gitea.com) approved these changes 2022-07-12 15:09:39 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
jouve (Migrated from gitea.com) reviewed 2022-07-13 16:52:45 +00:00
lunny (Migrated from gitea.com) approved these changes 2022-08-04 13:45:46 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
lunny
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#336
No description provided.
Delete Branch "refs/pull/336/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?