lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Add section describing versioning and update policy #347

Merged
pat-s merged 13 commits from update-policy into main 2023-03-08 17:14:34 +00:00
Conversation 3 Commits 13 Files Changed 1 +16
pat-s commented 2022-08-21 07:29:48 +00:00 (Migrated from gitea.com)
Copy Link

After recent discussions in Discord.

Feel free to modify as needed!

After recent discussions in Discord. Feel free to modify as needed!
justusbunsi (Migrated from gitea.com) reviewed 2022-08-21 07:29:59 +00:00
justusbunsi (Migrated from gitea.com) reviewed 2022-08-21 12:23:49 +00:00
README.md
justusbunsi (Migrated from gitea.com) commented 2022-08-21 12:25:14 +00:00
Copy Link
- values.yml
+ values.yaml
```diff - values.yml + values.yaml ```
README.md
justusbunsi (Migrated from gitea.com) commented 2022-08-21 12:28:36 +00:00
Copy Link

Do we speak of minor version bump or major version bump between 1.13 to 1.14?

I am thinking of the naming for semver major.minor.path but am not sure what's correct in the context of Gitea versioning.

Do we speak of minor version bump or major version bump between 1.13 to 1.14? I am thinking of the naming for semver `major.minor.path` but am not sure what's correct in the context of Gitea versioning.
justusbunsi (Migrated from gitea.com) commented 2022-08-21 14:15:19 +00:00
Copy Link

Gitea doesn't strictly follow semantic versioning as breaking changes do not increase the major version.
So in Gitea's case "minor" version bumps are actually "major". This is why I added the example to make it explicit and explain this case in more detail.

I'd also refer to it as "minor" as this is what is commonly used for the x.y.z logic. But I also see that others might do different. I think we can't discuss Gitea's general versioning approach here :D

How would you (re)phrase it?

Gitea doesn't strictly follow semantic versioning as breaking changes do not increase the major version. So in Gitea's case "minor" version bumps are actually "major". This is why I added the example to make it explicit and explain this case in more detail. I'd also refer to it as "minor" as this is what is commonly used for the x.y.z logic. But I also see that others might do different. I think we can't discuss Gitea's general versioning approach here :D How would you (re)phrase it?
justusbunsi (Migrated from gitea.com) commented 2022-08-21 16:43:17 +00:00
Copy Link

Probably exactly how you explained.

Gitea doesn't strictly follow [semantic versioning](https://semver.org/#summary) as breaking changes do not increase the major version. So in Gitea's case "minor" version bumps are actually "major".

as an addition to the sentence "Note that using the :1 will also...."

Probably exactly how you explained. ``` Gitea doesn't strictly follow [semantic versioning](https://semver.org/#summary) as breaking changes do not increase the major version. So in Gitea's case "minor" version bumps are actually "major". ``` as an addition to the sentence "Note that using the `:1` will also...."
README.md
justusbunsi (Migrated from gitea.com) commented 2022-08-21 12:23:49 +00:00
Copy Link

Loose end?

Loose end?
justusbunsi (Migrated from gitea.com) commented 2022-08-21 14:17:04 +00:00
Copy Link

Good catch!

Good catch!
pat-s commented 2022-09-07 06:56:27 +00:00 (Migrated from gitea.com)
Copy Link

blocked by #355

blocked by #355
luhahn (Migrated from gitea.com) reviewed 2022-09-25 20:27:19 +00:00
lunny (Migrated from gitea.com) reviewed 2022-09-25 20:27:28 +00:00
pat-s commented 2023-03-07 22:19:04 +00:00 (Migrated from gitea.com)
Copy Link

@justusbunsi Can we merge here?

@justusbunsi Can we merge here?
techknowlogick (Migrated from gitea.com) reviewed 2023-03-07 22:21:43 +00:00
README.md
techknowlogick (Migrated from gitea.com) commented 2023-03-07 22:21:43 +00:00
Copy Link

Can you use dl.gitea.com instead of the .io due to the recent CDN changes?

Can you use dl.gitea.com instead of the .io due to the recent CDN changes?
README.md
techknowlogick (Migrated from gitea.com) commented 2023-03-07 22:22:03 +00:00
Copy Link

Can you use considered instead of actually?

Can you use `considered` instead of `actually`?
lunny (Migrated from gitea.com) approved these changes 2023-03-08 15:21:47 +00:00
justusbunsi (Migrated from gitea.com) approved these changes 2023-03-08 15:34:37 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
justusbunsi commented 2023-03-08 15:36:18 +00:00 (Migrated from gitea.com)
Copy Link

@techknowlogick Anything left from your side?

@techknowlogick Anything left from your side?
techknowlogick (Migrated from gitea.com) approved these changes 2023-03-08 17:14:24 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
lunny
justusbunsi
techknowlogick
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#347
No description provided.
Delete Branch "update-policy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?