lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Make test pods optional and allow image override #360

Merged
ooms97 merged 6 commits from main into main 2023-03-09 15:25:45 +00:00
Conversation 5 Commits 6 Files Changed 3
+1236 -5583
ooms97 commented 2022-09-13 18:42:33 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

Description of the change

Make the test-connection Pod optional and override the wget container's image.

Benefits

Allows users to enable/disabled the test-connection Pod and override the wget container's image.

Possible drawbacks

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
### Description of the change Make the test-connection Pod optional and override the wget container's image. ### Benefits Allows users to enable/disabled the test-connection Pod and override the wget container's image. ### Possible drawbacks <!-- Describe any known limitations with your change --> ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [X] Breaking changes are documented in the `README.md`
justusbunsi (Migrated from gitea.com) reviewed 2022-09-25 13:07:45 +00:00
values.yaml
@@ -693,2 +473,4 @@
service:
port: 3306
persistence:
size: 10Gi
justusbunsi (Migrated from gitea.com) commented 2022-09-25 13:07:45 +00:00
Copy Link
Copy Source

A separate section is not necessary, IMO. Modifying the helm tests can be considered "advanced". ?

A separate section is not necessary, IMO. Modifying the helm tests can be considered "advanced". ?
justusbunsi (Migrated from gitea.com) commented 2022-10-07 22:10:27 +00:00
Copy Link
Copy Source

Great point, changes have been added! ?

Great point, changes have been added! ?
pat-s (Migrated from gitea.com) reviewed 2022-12-27 09:28:01 +00:00
templates/tests/test-http-connection.yaml
pat-s (Migrated from gitea.com) commented 2022-12-27 09:28:01 +00:00
Copy Link
Copy Source

Should we split this in image.name and image.tag to follow canonical conventions?

Should we split this in `image.name` and `image.tag` to follow canonical conventions?
pat-s (Migrated from gitea.com) approved these changes 2023-03-09 09:09:16 +00:00
pat-s (Migrated from gitea.com) left a comment
Copy Link
Copy Source

LGTM

LGTM
pat-s commented 2023-03-09 09:09:38 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

@justusbunsi Should we get that in if LGTM to you?

@justusbunsi Should we get that in if LGTM to you?
justusbunsi (Migrated from gitea.com) approved these changes 2023-03-09 15:25:00 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link
Copy Source

LGTM. Thanks for your contribution.

LGTM. Thanks for your contribution.
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
justusbunsi
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No labels kind/feature
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
lunny (Lunny Xiao)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#360
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?