lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Gpg init fails to import key #370 #371

Merged
dajoen74 merged 2 commits from fixgpgimport into main 2022-10-18 05:47:22 +00:00
Conversation 5 Commits 2 Files Changed 2 +1246 -5622
dajoen74 commented 2022-10-17 19:20:48 +00:00 (Migrated from gitea.com)
Copy Link

Description of the change

The init container for gpg key import doesn´t work. There is a not a tty error.

Benefits

This will run gpg in batch mode. Eliminating the tty error.

Possible drawbacks

None that I can think off.

Applicable issues

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
### Description of the change The init container for gpg key import doesn´t work. There is a not a tty error. ### Benefits This will run gpg in batch mode. Eliminating the tty error. ### Possible drawbacks None that I can think off. ### Applicable issues - fixes #370 ### Checklist - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [X] Breaking changes are documented in the `README.md`
techknowlogick (Migrated from gitea.com) approved these changes 2022-10-17 19:28:43 +00:00
justusbunsi commented 2022-10-17 19:49:57 +00:00 (Migrated from gitea.com)
Copy Link

I was wondering why no unit tests failed for this change, before realizing I missed adding one for the added code snipped.

Do you mind adding one, ensuring that the --batch flag never get removed again?

I was wondering why no unit tests failed for this change, before realizing I missed adding one for the added code snipped. Do you mind adding one, ensuring that the `--batch` flag never get removed again?
dajoen74 commented 2022-10-18 05:22:52 +00:00 (Migrated from gitea.com)
Copy Link

I'll give it a shot. First time writing a unit test for me.

I'll give it a shot. First time writing a unit test for me.
❤️ 1
dajoen74 commented 2022-10-18 05:36:59 +00:00 (Migrated from gitea.com)
Copy Link

This should do it.

This should do it.
justusbunsi (Migrated from gitea.com) approved these changes 2022-10-18 05:45:35 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No Reviewers
techknowlogick
justusbunsi
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#371
No description provided.
Delete Branch "fixgpgimport"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?