lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Temporary revert GPG feature for semver based retagging #373

Merged
justusbunsi merged 2 commits from refs/pull/373/head into main 2022-10-20 16:35:20 +00:00
Conversation 1 Commits 2 Files Changed 18 +22 -440
justusbunsi commented 2022-10-20 16:18:57 +00:00 (Migrated from gitea.com)
Copy Link

Feature #343 happens to be a breaking change when enabling .Values.signing but not specifying
any of the new private key properties. Tag v6.0.2 is therefore not following semantic versioning.

This temporarily reverts commit b8f0310c43 and a fix-up commit 57a1cd27d9
to retag 6.0.2 as 6.0.3.

Feature #343 happens to be a breaking change when enabling `.Values.signing` but not specifying any of the new private key properties. Tag `v6.0.2` is therefore not following semantic versioning. This temporarily reverts commit b8f0310c43bd71dd48ac92b70d8ebdb94d43c29b and a fix-up commit 57a1cd27d9a6cc014f425fabeadb0db34f242b0e to retag 6.0.2 as 6.0.3.
❤️ 1
techknowlogick (Migrated from gitea.com) reviewed 2022-10-20 16:19:29 +00:00
luhahn (Migrated from gitea.com) reviewed 2022-10-20 16:19:29 +00:00
pat-s (Migrated from gitea.com) reviewed 2022-10-20 16:19:30 +00:00
techknowlogick (Migrated from gitea.com) approved these changes 2022-10-20 16:24:15 +00:00
luhahn (Migrated from gitea.com) approved these changes 2022-10-20 16:33:15 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

lgtm

lgtm
viceice commented 2022-10-21 06:27:26 +00:00 (Migrated from gitea.com)
Copy Link

thankyou ❤️

thankyou :heart:
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
techknowlogick
luhahn
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#373
No description provided.
Delete Branch "refs/pull/373/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?