lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Ignore unrelated helm files from bundling #385

Merged
JSchlarb merged 2 commits from helm-ignore into main 2022-12-28 10:30:15 +00:00
Conversation 2 Commits 2 Files Changed 1 +5
JSchlarb commented 2022-12-28 07:49:05 +00:00 (Migrated from gitea.com)
Copy Link

Description of the change

Exluding non helm chart related files from release artifact

Benefits

Smaller release artifacts

Possible drawbacks

Exluded files not visible any within the artifact

Applicable issues

None

Additional information

None

⚠ BREAKING

None

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
<!-- Before you open the request please review the following guidelines and tips to help it be more easily integrated: - Describe the scope of your change - i.e. what the change does. - Describe any known limitations with your change. - Please run any tests or examples that can exercise your modified code. Thank you for contributing! We will try to review, test and integrate the change as soon as we can. --> ### Description of the change Exluding non helm chart related files from release artifact ### Benefits Smaller release artifacts ### Possible drawbacks Exluded files not visible any within the artifact ### Applicable issues None ### Additional information None ### ⚠ BREAKING None ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [x] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [x] Breaking changes are documented in the `README.md`
justusbunsi commented 2022-12-28 09:02:50 +00:00 (Migrated from gitea.com)
Copy Link

LICENSE file should always be included.

LICENSE file should always be included.
JSchlarb commented 2022-12-28 09:04:04 +00:00 (Migrated from gitea.com)
Copy Link

Good point!

Good point!
justusbunsi (Migrated from gitea.com) approved these changes 2022-12-28 09:23:57 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
pat-s (Migrated from gitea.com) approved these changes 2022-12-28 10:30:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
justusbunsi
pat-s
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#385
No description provided.
Delete Branch "helm-ignore"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?