lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Properly assert chart dependency inputs #409

New Issue
Open
opened 2023-02-27 09:14:49 +00:00 by pat-s · 0 comments
pat-s commented 2023-02-27 09:14:49 +00:00 (Migrated from gitea.com)
Copy Link

As the deps change their mappings from time to time, we should assert whether the user input in values.yaml adheres to their mappings.

No full-covering TODO list:

  • check used value mappings on our side
  • check used value mappings actually get used while templating
  • #571 check the application image app.kubernetes.io/version label against a fixed value on our side.
    This would ensure that automerges of "minor/patch" updates are actual minor/patch updates. Looking at you, https://github.com/bitnami/charts/issues/19596. 👀
As the deps change their mappings from time to time, we should assert whether the user input in `values.yaml` adheres to their mappings. No full-covering TODO list: - [ ] check used value mappings on _our_ side - [ ] check used value mappings actually get used while templating - [x] #571 check the application image ~~`app.kubernetes.io/version` label~~ against a fixed value on our side. This would ensure that automerges of "minor/patch" updates are actual minor/patch updates. Looking at you, https://github.com/bitnami/charts/issues/19596. 👀
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#409
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?