lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

test: use official unittest plugin #410

Merged
viceice merged 3 commits from refs/pull/410/head into main 2023-03-21 15:53:14 +00:00
Conversation 4 Commits 3 Files Changed 4 +6 -6
viceice commented 2023-03-07 12:48:24 +00:00 (Migrated from gitea.com)
Copy Link

Description of the change

Switch to official helm-unittest which is now alive again at https://github.com/helm-unittest/helm-unittest

Applicable issues

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
### Description of the change Switch to official `helm-unittest` which is now alive again at https://github.com/helm-unittest/helm-unittest ### Applicable issues - ref #199 ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [ ] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [ ] Breaking changes are documented in the `README.md`
justusbunsi commented 2023-03-07 15:27:44 +00:00 (Migrated from gitea.com)
Copy Link

Awesome, thanks for the PR. There is another mention of the current helm plugin in CONTRIBUTING.md that needs to be changed. Otherwise lgtm.

Awesome, thanks for the PR. There is another mention of the current helm plugin in `CONTRIBUTING.md` that needs to be changed. Otherwise lgtm.
👍 1 👀 1
pat-s (Migrated from gitea.com) approved these changes 2023-03-07 16:49:37 +00:00
pat-s (Migrated from gitea.com) reviewed 2023-03-21 05:37:46 +00:00
viceice commented 2023-03-21 05:38:08 +00:00 (Migrated from gitea.com)
Copy Link

Awesome, thanks for the PR. There is another mention of the current helm plugin in CONTRIBUTING.md that needs to be changed. Otherwise lgtm.

> Awesome, thanks for the PR. There is another mention of the current helm plugin in `CONTRIBUTING.md` that needs to be changed. Otherwise lgtm.
viceice commented 2023-03-21 05:38:34 +00:00 (Migrated from gitea.com)
Copy Link

Fixed the contributing guide ?

Fixed the contributing guide ?
justusbunsi (Migrated from gitea.com) approved these changes 2023-03-21 05:59:58 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
viceice commented 2023-03-21 12:43:48 +00:00 (Migrated from gitea.com)
Copy Link

@pat-s Can you please approve again. ?

@pat-s Can you please approve again. ?
pat-s (Migrated from gitea.com) approved these changes 2023-03-21 15:52:39 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
justusbunsi
pat-s
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/testing
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#410
No description provided.
Delete Branch "refs/pull/410/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?