lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Fix wrong reference to existingKey #415

Merged
towo merged 2 commits from main into main 2023-03-21 06:16:42 +00:00
Conversation 0 Commits 2 Files Changed 3 +3 -3
towo commented 2023-03-19 00:09:59 +00:00 (Migrated from gitea.com)
Copy Link

Description of the change

Fix a wrong reference to signing.existingKey, signing.existingSecret was what was meant and what is used in the chart.

Benefits

Less confusion when trying to use the Helm chart.

Possible drawbacks

Evangelists of existingKey storming the barricades even though existingKey is long dead.

Applicable issues

None, nobody noticed enough to care, apparently.

### Description of the change Fix a wrong reference to `signing.existingKey`, `signing.existingSecret` was what was meant and what is used in the chart. ### Benefits Less confusion when trying to use the Helm chart. ### Possible drawbacks Evangelists of `existingKey` storming the barricades even though `existingKey` is long dead. ### Applicable issues None, nobody noticed enough to care, apparently.
pat-s (Migrated from gitea.com) approved these changes 2023-03-20 10:08:39 +00:00
justusbunsi (Migrated from gitea.com) approved these changes 2023-03-21 06:15:25 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
justusbunsi
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#415
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?