Bump memcached to add arm64 support #422
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: lunny/helm-chart#422
Reference in New Issue
Block a user
No description provided.
Delete Branch "refs/pull/422/head"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
And allow overriding the
imagesection so users could possible also use other image tags.fix #285
@ -1164,3 +776,2 @@| ------------------------------------------------------- | ---------------------------------------------------------------- | ------- || `postgresql.enabled` | Enable PostgreSQL | `false` || `postgresql.global.postgresql.auth.password` | Password for the `gitea` user (overrides `auth.password`) | `gitea` || `postgresql.enabled` | Enable PostgreSQL | `true` |This should be
memcached.service.ports.memcached1cfcd6be690/bitnami/memcached/values.yaml (L390)↩︎@ -672,4 +431,4 @@## @section PostgreSQL### @param postgresql.enabled Enable PostgreSQLAren't those values the defaults of the memcached Chart1? If that's the case, we don't actually need them to specify in our Chart. All dependency Chart values can be overwritten by specifying them in a customized values.yaml.
We might miss to update them when bumping the dependency 😅.
cfcd6be690/bitnami/memcached/values.yaml (L70)↩︎@ -1164,3 +776,2 @@| ------------------------------------------------------- | ---------------------------------------------------------------- | ------- || `postgresql.enabled` | Enable PostgreSQL | `false` || `postgresql.global.postgresql.auth.password` | Password for the `gitea` user (overrides `auth.password`) | `gitea` || `postgresql.enabled` | Enable PostgreSQL | `true` |Don't forget to update
0f4e1e488a/templates/_helpers.tpl (L99)@ -1164,3 +776,2 @@| ------------------------------------------------------- | ---------------------------------------------------------------- | ------- || `postgresql.enabled` | Enable PostgreSQL | `false` || `postgresql.global.postgresql.auth.password` | Password for the `gitea` user (overrides `auth.password`) | `gitea` || `postgresql.enabled` | Enable PostgreSQL | `true` |Uhh nice find! And very nice footnote 😃
@ -672,4 +431,4 @@## @section PostgreSQL### @param postgresql.enabled Enable PostgreSQLThey are but I wanted to make it explicit for users that they can do so by listing them in
values.yml.Otherwise it might look one can only change
service.port.But yeah defining them requires updating them - maybe commenting them out might be better and a good middle-way to make them more "visible" without having maintenance burden?
Works and LGTM
@ -672,4 +431,4 @@## @section PostgreSQL### @param postgresql.enabled Enable PostgreSQLComments work for me. 👍 for leaving the tag empty in that comment.