add extraDeploy to add arbitrary objects to the release #441
Reference in New Issue
Block a user
No description provided.
Delete Branch "extra"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Signed-off-by: Cyril Jouve jv.cyril@gmail.com
Description of the change
add a new value
extraDeploy
to add arbitrary resourcesinspired by bitnami charts (example
Benefits
with the change, I can deploy additional resources and keep them consistent with the chart (reuse macro, same labels, etc)., same workflow (helm upgrade), etc
Possible drawbacks
Additional information
Checklist
values.yaml
and added to theREADME.md
using readme-generator-for-helmLGTM!
And thanks for the capitalization catch!
I understand we might want to allow users to include and reference other values. However I'm not the biggest fan, of the tpl function, since one might be able to reference literally everything.
In Addition (no worries, I won't block this PR) do we need this? I think everything not related directly to this chart should be kept outside.
This is just my personal preference I'm open to discussions here :)
do we need this
was my first reaction, too. Not blocking it either, but would be happy to discuss before a potential merge.I use it to add stuff like network policies
Network policies. I see 😃. Do you fancy reviving #306? I see you commented there as well.
This also explains the use of tpl function :)
Okay this is a neat way to include functionality, which is not yet implemented in the helm chart
@justusbunsi @luhahn Your take - no strong opinion from my side here.
Fine with me, adds more flexibility to the chart :)
@jouve As soon as the failing build is resolved this can be merged. 🙂
readme-generator-for-helm copies the comment into the readme :
but markdownlint -f capitalize "Gitea" between the quotes => as a workaround, I changes the quote to ` so that both agree
@jouve A side remark: would it be possible not to force-push in your PRs? By doing so we cannot infer what you changed since the last conversations and only see the overall changed files of the PR.
Is there a reason you always force-push instead of doing normal commits?
A force-push can make sense in situations where you are trying out something iteratively but want to have one clear commit message. Yet it becomes problematic once there is conversation happening and people want to track the changes.
Upon merge, we would do a squash commit anyway 🙂