lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Memcache: PROVIDER_CONFIG is not restored if altered previously #453

New Issue
Closed
opened 2023-06-02 10:13:30 +00:00 by pat-s · 5 comments
pat-s commented 2023-06-02 10:13:30 +00:00 (Migrated from gitea.com)
Copy Link

I just switched from redis-cluster to memcache and noticed that session.PROVIDER_CONFIG is not restored to the respective memcache DNS.

It is done for cache.HOST: https://gitea.com/gitea/helm-chart/src/branch/main/templates/_helpers.tpl#L233 and should most likely be done in the same way for session.PROVIDER_CONFIG.

I just switched from redis-cluster to memcache and noticed that `session.PROVIDER_CONFIG` is not restored to the respective memcache DNS. It is done for `cache.HOST`: https://gitea.com/gitea/helm-chart/src/branch/main/templates/_helpers.tpl#L233 and should most likely be done in the same way for `session.PROVIDER_CONFIG`.
justusbunsi commented 2023-06-02 11:38:26 +00:00 (Migrated from gitea.com)
Copy Link

Isn't that similar to #356?

Isn't that similar to #356?
pat-s commented 2023-06-02 11:43:03 +00:00 (Migrated from gitea.com)
Copy Link

Partly as the old config is not removed when switching session providers but the actual issue is that the chart is not defining memcache for session.

I made the issue in a hurry and I just realized that the chart is (most likely on purpose) not setting anything for config.session. I thought the default was memcache there as well but now I am not sure anymore...

Partly as the old config is not removed when switching session providers but the actual issue is that the chart is not defining memcache for session. I made the issue in a hurry and I just realized that the chart is (most likely on purpose) not setting anything for `config.session`. I thought the default was `memcache` there as well but now I am not sure anymore...
justusbunsi commented 2023-06-02 11:46:31 +00:00 (Migrated from gitea.com)
Copy Link

I believe the chart uses the default for sessions. Which is memory.

I believe the chart uses the default for sessions. Which is memory.
pat-s commented 2023-06-04 07:52:04 +00:00 (Migrated from gitea.com)
Copy Link

Good point. Then it's probably only #356 again and I should have set it to memory instead of memcache.

Given we already have memcache, it could also be used for session.

Good point. Then it's probably only #356 again and I should have set it to `memory` instead of `memcache`. Given we already have `memcache`, it could also be used for `session`.
pat-s commented 2023-11-15 18:26:41 +00:00 (Migrated from gitea.com)
Copy Link

Closing in favor of #356.

Closing in favor of #356.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#453
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?