lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Login to docker to fix workflow #526

Merged
pat-s merged 4 commits from refs/pull/526/head into main 2023-10-10 19:48:00 +00:00
Conversation 4 Commits 4 Files Changed 2 +59 -51
pat-s commented 2023-10-05 19:53:02 +00:00 (Migrated from gitea.com)
Copy Link

Same as for the release workflow.

Same as for the release workflow.
techknowlogick (Migrated from gitea.com) reviewed 2023-10-06 04:07:37 +00:00
techknowlogick (Migrated from gitea.com) left a comment
Copy Link

blocking this as it opens up secrets to PRs

blocking this as it opens up secrets to PRs
pat-s commented 2023-10-06 07:05:06 +00:00 (Migrated from gitea.com)
Copy Link

Good catch.

I see two solutions:

  • a read-only token
  • selectively approving PRs

I'd favor (1). Your opinion?

Good catch. I see two solutions: - a read-only token - selectively approving PRs I'd favor (1). Your opinion?
pat-s commented 2023-10-09 18:37:41 +00:00 (Migrated from gitea.com)
Copy Link

@techknowlogick I've used a personal read-only public token of my own Docker account now to move forward. If you have time, it would be great to add a token from the Gitea docker org. Public read-only tokens should only have a use case for rate limiting AFAICS.

@techknowlogick I've used a personal read-only public token of my own Docker account now to move forward. If you have time, it would be great to add a token from the Gitea docker org. Public read-only tokens should only have a use case for rate limiting AFAICS.
techknowlogick commented 2023-10-09 23:32:04 +00:00 (Migrated from gitea.com)
Copy Link

@pat-s I've created some temporary RO tokens DOCKER_RO_USERNAME and DOCKER_RO_PASSWORD under my personal username, as I'm having some trouble getting into the giteabot docker hub account. Once I get access, I'll be able to update them :)

@pat-s I've created some temporary RO tokens `DOCKER_RO_USERNAME` and `DOCKER_RO_PASSWORD` under my personal username, as I'm having some trouble getting into the giteabot docker hub account. Once I get access, I'll be able to update them :)
pat-s commented 2023-10-10 07:05:48 +00:00 (Migrated from gitea.com)
Copy Link

Thanks! Though this wouldn't have been needed as my last comment tried to communicate I already did the same with DOCKER_USERNAME_PUBLIC 😄

For now, I only need an approval here to move forward. I want to get the renovate updates auto-merged again.

Thanks! Though this wouldn't have been needed as my last comment tried to communicate I already did the same with `DOCKER_USERNAME_PUBLIC` 😄 For now, I only need an approval here to move forward. I want to get the renovate updates auto-merged again.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#526
No description provided.
Delete Branch "refs/pull/526/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?