lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Fix domain macro #560

Merged
justusbunsi merged 2 commits from refs/pull/560/head into main 2023-11-14 22:23:01 +00:00
Conversation 0 Commits 2 Files Changed 2 +68 -1
justusbunsi commented 2023-11-11 16:38:56 +00:00 (Migrated from gitea.com)
Copy Link

Description of the change

This supersedes #359 by fixing the fallback domain value when no ingress host is defined.

Memcached is not used anymore. PostgreSQL macro has already been fixed otherwise.

Checklist

  • Templating unittests are added
### Description of the change This supersedes #359 by fixing the fallback domain value when no ingress host is defined. Memcached is not used anymore. PostgreSQL macro has already been fixed otherwise. ### Checklist - [x] Templating unittests are added
pat-s (Migrated from gitea.com) reviewed 2023-11-13 17:34:30 +00:00
pat-s (Migrated from gitea.com) approved these changes 2023-11-14 22:18:11 +00:00
pat-s (Migrated from gitea.com) left a comment
Copy Link

LGTM, thanks! Nice tests!

LGTM, thanks! Nice tests!
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#560
No description provided.
Delete Branch "refs/pull/560/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?