Done: chore(config): migrate renovate config #575

2023-11-25T04:07:09Z

renovate-bot commented

2023-11-25 04:07:09 +00:00

(Migrated from gitea.com)

The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.

You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.

PLEASE NOTE: JSON5 config file migrated! All comments & trailing commas were removed.

🔕 Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.

❓ Got questions? Does something look wrong to you? Please don't hesitate to request help here.

This PR has been generated by Renovate Bot.

The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed. You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon. #### [PLEASE NOTE](https://docs.renovatebot.com/configuration-options#configmigration): JSON5 config file migrated! All comments & trailing commas were removed. 🔕 **Ignore**: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid. ❓ Got questions? Does something look wrong to you? Please don't hesitate to [request help here](https://github.com/renovatebot/renovate/discussions). --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

techknowlogick (Migrated from gitea.com) approved these changes 2023-11-25 04:09:30 +00:00

justusbunsi commented

2023-11-27 18:26:58 +00:00

(Migrated from gitea.com)

Renamed so that Renovate will provide future migration PRs. Weird behavior. :D

pat-s commented

2023-11-27 21:09:42 +00:00

(Migrated from gitea.com)

Why wouldn't it provide future updates with the old title?

justusbunsi commented

2023-11-27 21:26:02 +00:00

(Migrated from gitea.com)

@pat-s

Why wouldn't it provide future updates with the old title?

Renovate uses PR branch name and PR title to determine whether a PR was closed to skip this change. Since the migration will always result in the same branch name, Renovate thinks this PR was closed to skip and never provide a migration pr again. That's why renaming the PR title helps renovate to see this already merged PR as it is: already merged. And therefore, Renovate will provide future migration PRs.

I think this is a side-effect from the "skip a version of a dependency" feature.

@pat-s >Why wouldn't it provide future updates with the old title? Renovate uses PR branch name and PR title to determine whether a PR was closed to skip this change. Since the migration will always result in the same branch name, Renovate thinks this PR was closed to skip and never provide a migration pr again. That's why renaming the PR title helps renovate to see this already merged PR as it is: already merged. And therefore, Renovate will provide future migration PRs. I think this is a side-effect from the "skip a version of a dependency" feature.

pat-s commented

2023-11-29 09:27:30 +00:00

(Migrated from gitea.com)

Ah, because in other cases, all PR titles are unique and never re-used. And if one exists, renovate will not create another one.

But given this migration PR is also an automated one, this looks like a bug to me which should be reported (if it isn't already known). This would maybe then required to versionize the config file or add a running ID to such migration PRs but this is already going too into much detail.

Did you check for the issue upstream already with the idea of reporting it?

Ah, because in other cases, all PR titles are unique and never re-used. And if one exists, renovate will not create another one. But given this migration PR is also an automated one, this looks like a bug to me which should be reported (if it isn't already known). This would maybe then required to versionize the config file or add a running ID to such migration PRs but this is already going too into much detail. Did you check for the issue upstream already with the idea of reporting it?

justusbunsi commented

2023-11-29 12:45:10 +00:00

(Migrated from gitea.com)

Haven't looked for such issue yet. I am currently living the rename life. 😅

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#575