lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Allowing Custom Labels in SVC Templates #597

Merged
remogeissbuehler merged 5 commits from main into main 2024-01-13 09:58:31 +00:00
Conversation 3 Commits 5 Files Changed 5 +63
remogeissbuehler commented 2024-01-07 01:05:50 +00:00 (Migrated from gitea.com)
Copy Link

Description of the change

The change allows users of this chart to specify custom labels for the HTTP & SSH Services that get deployed. They are optional and if given are added to the standard list of labels.

Benefits

Certain use cases require labelling services to be able to select them in other places. Specifiying them directly in the helm chart avoids having to label by hand everytime.

Concrete Use Case Example: Cilium Layer 2 Announcements require selecting services to announce via labels (see docs). I would like to add a label to the SSH service, but not the HTTP Service (which is handled via an ingress).

Possible drawbacks

I don't see any, using this feature is optional :)

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
  • Templating unittests are added
<!-- Before you open the request please review the following guidelines and tips to help it be more easily integrated: - Describe the scope of your change - i.e. what the change does. - Describe any known limitations with your change. - Please run any tests or examples that can exercise your modified code. Thank you for contributing! We will try to review, test and integrate the change as soon as we can. --> ### Description of the change The change allows users of this chart to specify custom labels for the HTTP & SSH Services that get deployed. They are optional and if given are added to the standard list of labels. <!-- Describe the scope of your change - i.e. what the change does. --> ### Benefits Certain use cases require labelling services to be able to select them in other places. Specifiying them directly in the helm chart avoids having to label by hand everytime. Concrete Use Case Example: Cilium Layer 2 Announcements require selecting services to announce via labels (see [docs](https://docs.cilium.io/en/stable/network/l2-announcements/#service-selector)). I would like to add a label to the SSH service, but not the HTTP Service (which is handled via an ingress). <!-- What benefits will be realized by the code change? --> ### Possible drawbacks I don't see any, using this feature is optional :) <!-- Describe any known limitations with your change --> ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [X] Breaking changes are documented in the `README.md` - [X] Templating unittests are added
pat-s commented 2024-01-08 12:46:03 +00:00 (Migrated from gitea.com)
Copy Link

@remogeissbuehler Thanks for contributing! LGTM overall, thanks also for adding unit tests directly. Only a linting issue left.

@remogeissbuehler Thanks for contributing! LGTM overall, thanks also for adding unit tests directly. Only a linting issue left.
remogeissbuehler commented 2024-01-08 21:29:29 +00:00 (Migrated from gitea.com)
Copy Link

Sorry about that! Should be fixed. Thanks for the swift feedback @pat-s :)

Sorry about that! Should be fixed. Thanks for the swift feedback @pat-s :)
pat-s (Migrated from gitea.com) approved these changes 2024-01-10 09:37:38 +00:00
pat-s commented 2024-01-10 09:38:23 +00:00 (Migrated from gitea.com)
Copy Link

LGTM, I'll wait with merge in case @justusbunsi has some more thoughts about it. Should likely be good for the next release.

LGTM, I'll wait with merge in case @justusbunsi has some more thoughts about it. Should likely be good for the next release.
justusbunsi (Migrated from gitea.com) approved these changes 2024-01-13 09:55:49 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM. Thanks for the addition. Appreciate your use case in the PR description.

LGTM. Thanks for the addition. Appreciate your use case in the PR description.
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
justusbunsi
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#597
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?