Storage Class don´t use global.storageClass #601

New Issue

2024-01-15T17:39:43Z

florianspk commented

2024-01-15 17:39:43 +00:00

(Migrated from gitea.com)

Hi Team,

I wanted to bring to your attention a potential issue in our Helm chart for the repository in question. While reviewing the code, I noticed that the gitea.persistence.storageClass function is defined but not utilized. This becomes problematic when setting a value in global.storageClass.

Here is a snippet for reference:

{{- if .Values.persistence.storageClass }}
  storageClassName: {{ .Values.persistence.storageClass }}
{{- end }}
{{- with .Values.persistence.volumeName }}
  volumeName: {{ . }}
{{- end }}

It seems that the gitea.persistence.storageClass is not being considered when specifying a value in global.storageClass. This could potentially lead to unexpected behavior or configuration issues.

I plan to address this issue by submitting a pull request with the necessary changes. Let me know if you have any concerns or if there's anything specific you'd like me to consider in the proposed fix.

Best regards,
Florianspk

Hi Team, I wanted to bring to your attention a potential issue in our Helm chart for the repository in question. While reviewing the code, I noticed that the **gitea.persistence.storageClass** function is defined but not utilized. This becomes problematic when setting a value in **global.storageClass**. Here is a snippet for reference: ```yaml {{- if .Values.persistence.storageClass }} storageClassName: {{ .Values.persistence.storageClass }} {{- end }} {{- with .Values.persistence.volumeName }} volumeName: {{ . }} {{- end }} ``` It seems that the **gitea.persistence.storageClass** is not being considered when specifying a value in **global.storageClass**. This could potentially lead to unexpected behavior or configuration issues. I plan to address this issue by submitting a pull request with the necessary changes. Let me know if you have any concerns or if there's anything specific you'd like me to consider in the proposed fix. Best regards, Florianspk

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#601