lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Unclearity with SSH settings #605

New Issue
Closed
opened 2024-01-22 12:22:44 +00:00 by Tucker-glitch · 0 comments
Tucker-glitch commented 2024-01-22 12:22:44 +00:00 (Migrated from gitea.com)
Copy Link

Hi,

I think there are some improvements which could be made to how the ssh set up works. It seems to me that with the 10.0.0 release the default of the image was set to rootless and with this the new SSH_LISTEN_PORT parameter was introduced. I have disabled the rootless image via the values file and it seems that the inbuilt ssh server also uses the SSH_LISTEN_PORT parameter which by default is 2222. Is this intended behavior? If yes what does the SSH_PORT parameter do? If the SSH_PORT parameter is now not being used anymore maybe it would be better to remove it.

The service for ssh also uses the SSH_LISTEN_PORT parameter to create a target port of SSH_LISTEN_PORT. By default though the service is set up as headless service meaning no port translation would be applied. Maybe we could remove the targetPort if the clusterIp is set to none as this was confusing to me and might also be confusing to other users.

ssh:
type: ClusterIP
port: 22
clusterIP: None
loadBalancerIP:

Lastly, for some reason my ssh configs were incorrectly assigned to root user and group. The start script was not able to update these to the correct 1000:1000 group. Could there be an issue with the script only applying to the ssh parent folder and not e.g. the authorized keys?

I am happy to work on a pull request if these indeed turn out to be some unclearities but wanted to first dicuss if I understand the configurations correctly.

Hi, I think there are some improvements which could be made to how the ssh set up works. It seems to me that with the 10.0.0 release the default of the image was set to rootless and with this the new SSH_LISTEN_PORT parameter was introduced. I have disabled the rootless image via the values file and it seems that the inbuilt ssh server also uses the SSH_LISTEN_PORT parameter which by default is 2222. Is this intended behavior? If yes what does the SSH_PORT parameter do? If the SSH_PORT parameter is now not being used anymore maybe it would be better to remove it. The service for ssh also uses the SSH_LISTEN_PORT parameter to create a target port of SSH_LISTEN_PORT. By default though the service is set up as headless service meaning no port translation would be applied. Maybe we could remove the targetPort if the clusterIp is set to none as this was confusing to me and might also be confusing to other users. > ssh: type: ClusterIP port: 22 clusterIP: None loadBalancerIP: Lastly, for some reason my ssh configs were incorrectly assigned to root user and group. The start script was not able to update these to the correct 1000:1000 group. Could there be an issue with the script only applying to the ssh parent folder and not e.g. the authorized keys? I am happy to work on a pull request if these indeed turn out to be some unclearities but wanted to first dicuss if I understand the configurations correctly.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#605
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?