Namespace inconsistencies #623

New Issue

2024-03-02T08:48:07Z

absolutejam commented

2024-03-02 08:48:07 +00:00

(Migrated from gitea.com)

Hey!

First off, I have to say what an awesome product Gitea is! 👏

I'm currently deploying Gitea to a local cluster and I noticed that the helm chart will not apply the Helm release namespace to the actual Gitea deployment, meaning that it ends up in the default namespace unless applied with a namespace flag.

Since I'm using cdk8s, my resulting manifests have no namespace, and I can override this when applying, but there's some inconsistency as other components do apply the namespace:

Gitea deployment - No namespace
Service account - Respects the relesae namspace ({{ .Release.Namespace | quote }})
Bitnami postgres & redis child charts - Respect the release namespace.

I know that different projects provided different means for this (.Release.Namespace, .Values.namespaceOverride, etc.) but I think most projects have standardised on .Release.Namespace now.

Hey! First off, I have to say what an awesome product Gitea is! 👏 I'm currently deploying Gitea to a local cluster and I noticed that the helm chart will not apply the Helm release namespace to the actual Gitea deployment, meaning that it ends up in the default namespace unless applied with a namespace flag. Since I'm using `cdk8s`, my resulting manifests have no namespace, and I can override this when applying, but there's some inconsistency as other components do apply the namespace: - [Gitea deployment](https://gitea.com/gitea/helm-chart/src/branch/main/templates/gitea/deployment.yaml) - No namespace - [Service account](https://gitea.com/gitea/helm-chart/src/branch/main/templates/gitea/serviceaccount.yaml) - Respects the relesae namspace (`{{ .Release.Namespace | quote }}`) - Bitnami [postgres](https://github.com/bitnami/charts/blob/main/bitnami/postgresql/templates/primary/statefulset.yaml) & redis child charts - Respect the release namespace. I know that different projects provided different means for this (`.Release.Namespace`, `.Values.namespaceOverride`, etc.) but I think most projects have standardised on `.Release.Namespace` now.

justusbunsi commented

2024-03-02 13:21:08 +00:00

(Migrated from gitea.com)

Fair point. If you can, please open a PR to fix this.

👍 1

absolutejam commented

2024-03-02 20:53:50 +00:00

(Migrated from gitea.com)

More than happy to, just wanted to check if this is something you wanted me to pursue first.

jessesanford commented

2024-03-17 01:44:53 +00:00

(Migrated from gitea.com)

Check #630 for expanded use case for the implementation @absolutejam if you get to the PR before me please take it into account. Otherwise I believe my straw man solution should help you as well.

justusbunsi commented

2024-10-08 16:41:29 +00:00

(Migrated from gitea.com)

Resolved by #713

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#623