lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Quote image tag #641

Merged
pat-s merged 7 commits from refs/pull/641/head into main 2024-05-02 08:05:26 +00:00
Conversation 2 Commits 7 Files Changed 2 +18 -1
pat-s commented 2024-04-16 08:25:23 +00:00 (Migrated from gitea.com)
Copy Link

fix #631

fix #631
justusbunsi commented 2024-05-01 17:49:44 +00:00 (Migrated from gitea.com)
Copy Link

@pat-s It seems quote was not the right method to use here. There is a toString that work like you expected. I leave it up to you to merge, after you had the change to review my changes.

@pat-s It seems `quote` was not the right method to use here. There is a `toString` that work like you expected. I leave it up to you to merge, after you had the change to review my changes.
pat-s commented 2024-05-02 08:05:18 +00:00 (Migrated from gitea.com)
Copy Link

Ah, nice! I was wondering a bit when I tried it, but had no time to dig deeper...

I've got to check what quote is actually doing then and in which situations it should be used. (looks like it really "only" quotes the value but doesn't do a type change - which seems required here?)

Ah, nice! I was wondering a bit when I tried it, but had no time to dig deeper... I've got to check what `quote` is actually doing then and in which situations it should be used. (looks like it really "only" quotes the value but doesn't do a type change - which seems required here?)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#641
No description provided.
Delete Branch "refs/pull/641/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?