lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

add deployment labels to deployment #649

Merged
dcrussell merged 3 commits from main into main 2024-05-02 04:43:42 +00:00
Conversation 6 Commits 3 Files Changed 2
+229 -2417
dcrussell commented 2024-04-29 16:59:03 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

Description of the change

Applies deployment.labels to the deployment itself.

Benefits

Allows the user to add labels to the deployment.

Possible drawbacks

None

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
  • Templating unittests are added
### Description of the change Applies `deployment.labels` to the deployment itself. ### Benefits Allows the user to add labels to the deployment. ### Possible drawbacks None ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [X] Breaking changes are documented in the `README.md` - [X] Templating unittests are added
pat-s (Migrated from gitea.com) reviewed 2024-04-29 16:59:04 +00:00
justusbunsi commented 2024-04-29 17:21:43 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

@dcrussell please add a unittest that ensure this feature long-term. Thanks for proposing this addition.

@dcrussell please add a unittest that ensure this feature long-term. Thanks for proposing this addition.
dcrussell commented 2024-04-29 21:41:48 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

never used helm unittests before. wasn't sure where to add it.. basic seemed sensible to me.

never used helm unittests before. wasn't sure where to add it.. basic seemed sensible to me.
dcrussell commented 2024-05-01 14:57:05 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

@justusbunsi am i missing something else on this pr ?

@justusbunsi am i missing something else on this pr ?
justusbunsi commented 2024-05-01 16:57:05 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

@justusbunsi am i missing something else on this pr ?

https://gitea.com/gitea/helm-chart/actions/runs/812/jobs/0 failure is related. Please add the missing empty line at the end. 😆

Otherwise, good to be merged.

> @justusbunsi am i missing something else on this pr ? https://gitea.com/gitea/helm-chart/actions/runs/812/jobs/0 failure is related. Please add the missing empty line at the end. 😆 Otherwise, good to be merged.
😆 1
justusbunsi (Migrated from gitea.com) approved these changes 2024-05-02 04:42:36 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link
Copy Source

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
justusbunsi
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
lunny (Lunny Xiao)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#649
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?