Add non-clustered redis as sub-chart #672

2024-07-02T08:44:40Z

pat-s commented

2024-07-02 08:44:40 +00:00

(Migrated from gitea.com)

Supersedes #559 (@julienym thanks a lot for the initial work, I just cleaned up and added some minor edits. Needed to do so in a new branch as I can't directly edit your fork.)

@justusbunsi I've tested this in a fresh install without issues. Given the tests added by @julienym I am fine with merging this. I'll leave this open a few days so you get a chance to take a final look. No worries, if you have no time, we can always make post-merge adjustments/fixes.

Supersedes #559 (@julienym thanks a lot for the initial work, I just cleaned up and added some minor edits. Needed to do so in a new branch as I can't directly edit your fork.) @justusbunsi I've tested this in a fresh install without issues. Given the tests added by @julienym I am fine with merging this. I'll leave this open a few days so you get a chance to take a final look. No worries, if you have no time, we can always make post-merge adjustments/fixes.

justusbunsi (Migrated from gitea.com) reviewed 2024-07-02 08:44:41 +00:00

justusbunsi commented

2024-07-02 16:14:57 +00:00

(Migrated from gitea.com)

🫡 Will take a closer look in the next days. Thanks for the ping.

justusbunsi (Migrated from gitea.com) approved these changes 2024-07-05 19:19:24 +00:00

justusbunsi (Migrated from gitea.com) left a comment

As you can see, I changed a few things. My commit messages should be descriptive. If not, let me know.
LGTM now. I keep it up to you to merge this PR. That way you have the chance to review my changes.

As you can see, I changed a few things. My commit messages should be descriptive. If not, let me know. LGTM now. I keep it up to you to merge this PR. That way you have the chance to review my changes.

Makefile

justusbunsi (Migrated from gitea.com) commented

2024-07-05 19:19:24 +00:00

Thinking out loud:
There was a time when the unittest plugin didn't recognize the test files on root level when using that pattern. Nowadays this works. So in theory we could remove the 2nd and 3rd -f. But adding them will prevent possible regressions in the unittest plugin which would disable our checks. That's why I added the new file. :)

Thinking out loud: There was a time when the unittest plugin didn't recognize the test files on root level when using that pattern. Nowadays this works. So in theory we could remove the 2nd and 3rd `-f`. But adding them will prevent possible regressions in the unittest plugin which would disable our checks. That's why I added the new file. :)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#672