lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Add 'extraContainers' parameter. #697

Merged
rossigee merged 12 commits from sidecar-containers into main 2024-10-18 13:44:38 +00:00
Conversation 4 Commits 12 Files Changed 4 +32 -1
rossigee commented 2024-08-07 12:47:17 +00:00 (Migrated from gitea.com)
Copy Link

Allows the user to run their own sidecar containers.

Description of the change

Adds an 'extraContainers' parameter.

Benefits

Users will be able to run sidecar containers as required by their environment.

Possible drawbacks

N/A

Applicable issues

Checklist

Allows the user to run their own sidecar containers. ### Description of the change Adds an 'extraContainers' parameter. ### Benefits Users will be able to run sidecar containers as required by their environment. ### Possible drawbacks N/A ### Applicable issues * gitea/helm-chart#696 ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm)
pat-s (Migrated from gitea.com) reviewed 2024-08-07 12:47:17 +00:00
pat-s commented 2024-08-09 12:16:40 +00:00 (Migrated from gitea.com)
Copy Link

Thanks for contributing!

Could you add some tests following the existing ones (via helm-unittests)?

(I guess we should finally add this to the PR template).

Thanks for contributing! Could you add some tests following the existing ones (via `helm-unittests`)? (I guess we should finally add this to the PR template).
pat-s commented 2024-08-28 08:26:29 +00:00 (Migrated from gitea.com)
Copy Link

ping @rossigee

ping @rossigee
rossigee commented 2024-09-06 03:01:49 +00:00 (Migrated from gitea.com)
Copy Link

@pat-s - I'm not familiar with helm-unittests. I've added a test, but if I try to run it manually...

~/src/gitea/helm-chart$ helm unittest . -f unittests/deployment/sidecar-container.yaml 

### Chart [ gitea ] .

 FAIL  sidecar container	unittests/deployment/sidecar-container.yaml
	- supports adding a sidecar container
		Error: template: gitea/templates/gitea/deployment.yaml:32:28: executing "gitea/templates/gitea/deployment.yaml" at <include (print $.Template.BasePath "/gitea/config.yaml") .>: error calling include: template: no template "gitea/templates/gitea/config.yaml" associated with template "gotpl"


Charts:      1 failed, 0 passed, 1 total
Test Suites: 1 failed, 0 passed, 1 total
Tests:       1 failed, 1 errored, 0 passed, 1 total
Snapshot:    0 passed, 0 total
Time:        12.268632ms

Error: plugin "unittest" exited with error

The existing tests also fail with a similar error message, so I assume it's something I have/haven't done locally.

@pat-s - I'm not familiar with `helm-unittests`. I've added a test, but if I try to run it manually... ``` ~/src/gitea/helm-chart$ helm unittest . -f unittests/deployment/sidecar-container.yaml ### Chart [ gitea ] . FAIL sidecar container unittests/deployment/sidecar-container.yaml - supports adding a sidecar container Error: template: gitea/templates/gitea/deployment.yaml:32:28: executing "gitea/templates/gitea/deployment.yaml" at <include (print $.Template.BasePath "/gitea/config.yaml") .>: error calling include: template: no template "gitea/templates/gitea/config.yaml" associated with template "gotpl" Charts: 1 failed, 0 passed, 1 total Test Suites: 1 failed, 0 passed, 1 total Tests: 1 failed, 1 errored, 0 passed, 1 total Snapshot: 0 passed, 0 total Time: 12.268632ms Error: plugin "unittest" exited with error ``` The existing tests also fail with a similar error message, so I assume it's something I have/haven't done locally.
pat-s commented 2024-09-11 12:59:32 +00:00 (Migrated from gitea.com)
Copy Link

@rossigee Try adding - templates/gitea/config.yaml under templates: as shown in the existing deployment unittests.

@rossigee Try adding ` - templates/gitea/config.yaml` under `templates:` as shown in the existing deployment unittests.
👍 1
justusbunsi (Migrated from gitea.com) approved these changes 2024-10-18 13:43:02 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM. Thanks for your contribution. Sorry for the delayed response.

LGTM. Thanks for your contribution. Sorry for the delayed response.
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
justusbunsi
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#697
No description provided.
Delete Branch "sidecar-containers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?