Integrate NOVUM-RGI chart into the official helm chart. #7

2020-07-30T13:29:58Z

luhahn commented

2020-07-30 13:29:58 +00:00

(Migrated from gitea.com)

As discussed in Discord here's my PR to migrate NOVUM-RGI chart into the official helm chart.

First of all, i know that's a lot of stuff. But I gave jfeltens original chart a big rework since a lot of the approaches are deprecated.

What has changed:

app.ini is almost completly configurable with the values
gitea will be deployed as a statefulset, which is much easier than handling the PVC directly (and also helm best practice)
requirements.yaml is deprecated and replaced with Charts.yaml dependencies:
Postgresql, Mysql and Memcached are included as helm dependencies. This enables us to use the initialization in the original charts instead of caring in hard coded pods.
MariaDB was abandoned, sorry for that. But I can easily readd this again, if desired.
Replaced the README.md with NOVUM-RGI Readme md, since the download of the current state is avaiable there. Also it includes all the app.ini configuration.
An init container waits for the Database to be deployed and than adds admin user and ldap settings. Also it is upgradable, since we're either creating a new user, or if the user exists update the password. Same for ldap settings.

I'm open for discussions about what to actually migrate and what not :)

As discussed in Discord here's my PR to migrate NOVUM-RGI chart into the official helm chart. First of all, i know that's a lot of stuff. But I gave jfeltens original chart a big rework since a lot of the approaches are deprecated. What has changed: - app.ini is almost completly configurable with the values - gitea will be deployed as a statefulset, which is much easier than handling the PVC directly (and also helm best practice) - requirements.yaml is deprecated and replaced with Charts.yaml dependencies: - Postgresql, Mysql and Memcached are included as helm dependencies. This enables us to use the initialization in the original charts instead of caring in hard coded pods. - MariaDB was abandoned, sorry for that. But I can easily readd this again, if desired. - Replaced the README.md with NOVUM-RGI Readme md, since the download of the current state is avaiable there. Also it includes all the app.ini configuration. - An init container waits for the Database to be deployed and than adds admin user and ldap settings. Also it is upgradable, since we're either creating a new user, or if the user exists update the password. Same for ldap settings. I'm open for discussions about what to actually migrate and what not :)

lunny (Migrated from gitea.com) reviewed 2020-07-30 13:51:49 +00:00

techknowlogick (Migrated from gitea.com) reviewed 2020-07-30 13:51:53 +00:00

cdrage (Migrated from gitea.com) reviewed 2020-07-30 13:52:00 +00:00

lunny commented

2020-07-31 03:19:38 +00:00

(Migrated from gitea.com)

@luhahn Could you change the title to a suitable title, current is too simple.

lunny (Migrated from gitea.com) reviewed 2020-08-04 08:16:20 +00:00

lafriks (Migrated from gitea.com) reviewed 2020-08-07 09:12:11 +00:00

lafriks (Migrated from gitea.com) reviewed 2020-08-07 09:14:09 +00:00

lunny (Migrated from gitea.com) reviewed 2020-08-10 09:03:02 +00:00

lunny (Migrated from gitea.com) approved these changes 2020-08-10 13:04:47 +00:00

lunny (Migrated from gitea.com) left a comment

I think we could merge this one and add some ci tests after.

zeripath (Migrated from gitea.com) reviewed 2020-08-15 18:13:58 +00:00

zeripath (Migrated from gitea.com) reviewed 2020-08-15 18:14:27 +00:00

zeripath (Migrated from gitea.com) reviewed 2020-08-15 18:18:07 +00:00

zeripath (Migrated from gitea.com) reviewed 2020-08-15 18:23:29 +00:00

zeripath (Migrated from gitea.com) reviewed 2020-08-15 18:26:09 +00:00

zeripath (Migrated from gitea.com) reviewed 2020-08-17 15:17:10 +00:00

luhahn commented

2020-08-17 15:26:10 +00:00

(Migrated from gitea.com)

As suggested from @zeripath we changed the configuration part of the app.ini to a more generic approach. It's now possible to use all the Configurations in gitea.config

gitea:
    config:
      APP_NAME: "Gitea: With a cup of tea."
      repository:
        ROOT: "~/gitea-repositories"
      repository.pull-request:
        WORK_IN_PROGRESS_PREFIXES: "WIP:,[WIP]:"

As suggested from @zeripath we changed the configuration part of the app.ini to a more generic approach. It's now possible to use all the [Configurations](https://docs.gitea.io/en-us/config-cheat-sheet/) in gitea.config ```yaml gitea: config: APP_NAME: "Gitea: With a cup of tea." repository: ROOT: "~/gitea-repositories" repository.pull-request: WORK_IN_PROGRESS_PREFIXES: "WIP:,[WIP]:" ```

zeripath (Migrated from gitea.com) reviewed 2020-08-20 12:14:38 +00:00

zeripath (Migrated from gitea.com) approved these changes 2020-08-23 09:31:10 +00:00

zeripath (Migrated from gitea.com) left a comment

Things with the app.ini look much better - this autogeneration will prevent
having to constantly change the chart to add more features.

Caveats with this review:

I'm assuming that the ldap auth addition code is correct.
Need to check that the Copyright header is OK

Otherwise, LGTM

Things with the app.ini look much better - this autogeneration will prevent having to constantly change the chart to add more features. Caveats with this review: * I'm assuming that the ldap auth addition code is correct. * Need to check that the Copyright header is OK Otherwise, LGTM

techknowlogick commented

2020-08-23 17:54:06 +00:00

(Migrated from gitea.com)

Copyright header in LICENSE file is fine (for this PR at least)

techknowlogick (Migrated from gitea.com) approved these changes 2020-08-23 17:54:25 +00:00

techknowlogick (Migrated from gitea.com) left a comment

Thanks for PR

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#7