lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Fix probe definition overrides #717

Merged
justusbunsi merged 5 commits from refs/pull/717/head into main 2024-10-18 15:09:15 +00:00
Conversation 1 Commits 5 Files Changed 3 +209 -3
justusbunsi commented 2024-10-18 14:22:12 +00:00 (Migrated from gitea.com)
Copy Link

Description of the change

This fixes an issue when trying to apply a custom probe that is not tcpSocket.

Benefits

Custom probes 🥳

Applicable issues

Checklist

  • Templating unittests are added
### Description of the change This fixes an issue when trying to apply a custom probe that is not `tcpSocket`. ### Benefits Custom probes 🥳 ### Applicable issues - Fixes #694 ### Checklist - [x] Templating unittests are added
pat-s (Migrated from gitea.com) reviewed 2024-10-18 15:06:38 +00:00
justusbunsi commented 2024-10-18 15:08:50 +00:00 (Migrated from gitea.com)
Copy Link

@pat-s I'll take the liberty of merging this without your review. In my opinion, the tests back it up very well.

@pat-s I'll take the liberty of merging this without your review. In my opinion, the tests back it up very well.
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#717
No description provided.
Delete Branch "refs/pull/717/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?