Better default for labels might be needed for actions.statefulset.actrunner.config #725

New Issue

2024-11-12T00:10:34Z

kingphil commented

2024-11-12 00:10:34 +00:00

(Migrated from gitea.com)

The absence of an actions.statefulset:

  enabled: true
  existingSecret: gitea-admin-secret
  existingSecretKey: token

Results in a label that will likely explode in a new uesr's face:

kubectl exec -ti statefulset/gitea-act-runner -c act-runner -- cat .runner

{
[snip]
  "labels": [
    "ubuntu-latest:host"
  ]
}

The introduction of statefulset.actRunner.config results in saner defaults:

  enabled: true
  existingSecret: gitea-admin-secret
  existingSecretKey: token
  statefulset:
    actRunner:
      config: |
        log:
          level: debug
        cache:
          enabled: false

{
[snip]
  "labels": [
    "ubuntu-latest:docker://gitea/runner-images:ubuntu-latest",
    "ubuntu-22.04:docker://gitea/runner-images:ubuntu-22.04",
    "ubuntu-20.04:docker://gitea/runner-images:ubuntu-20.04"
  ]
}

I happened to solve this by being more explicit in my Helm chart values (while also bumping the versions), but I doubt this is intel that you need. I'm certain you see the best solution:

  enabled: true
  statefulset:
    actRunner:
      config: |
        log:
          level: debug
        cache:
          enabled: false
        runner:
          labels:
            - "ubuntu-latest:docker://node:22-bookworm"

The absence of an actions.statefulset: ```actions: enabled: true existingSecret: gitea-admin-secret existingSecretKey: token ``` Results in a label that will likely explode in a new uesr's face: ``` kubectl exec -ti statefulset/gitea-act-runner -c act-runner -- cat .runner { [snip] "labels": [ "ubuntu-latest:host" ] } ``` The introduction of statefulset.actRunner.config results in saner defaults: ```actions: enabled: true existingSecret: gitea-admin-secret existingSecretKey: token statefulset: actRunner: config: | log: level: debug cache: enabled: false ``` ```$ kubectl exec -ti statefulset/gitea-act-runner -c act-runner -- cat .runner { [snip] "labels": [ "ubuntu-latest:docker://gitea/runner-images:ubuntu-latest", "ubuntu-22.04:docker://gitea/runner-images:ubuntu-22.04", "ubuntu-20.04:docker://gitea/runner-images:ubuntu-20.04" ] } ``` I happened to solve this by being more explicit in my Helm chart values (while also bumping the versions), but I doubt this is intel that you need. I'm certain you see the best solution: ```actions: enabled: true statefulset: actRunner: config: | log: level: debug cache: enabled: false runner: labels: - "ubuntu-latest:docker://node:22-bookworm" ```

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#725