lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

bugfix/ingress-capabilities-query #78

Merged
skuethe merged 2 commits from refs/pull/78/head into master 2020-12-08 12:57:52 +00:00
Conversation 5 Commits 2 Files Changed 1 +3 -3
skuethe commented 2020-12-04 09:15:43 +00:00 (Migrated from gitea.com)
Copy Link

I didn't find any contributing guidelines, so bare with me if this is not the preferred way for fixes :)

Also just "highjacking" the "fix-ingress" branch for this. Should fix #77

I didn't find any contributing guidelines, so bare with me if this is not the preferred way for fixes :) Also just "highjacking" the "fix-ingress" branch for this. Should fix [#77](https://gitea.com/gitea/helm-chart/issues/77)
luhahn commented 2020-12-04 10:55:53 +00:00 (Migrated from gitea.com)
Copy Link

Hi there,

please point the pull request onto master instead of fix-ingress branch. Also please rebase your branch onto master, since fix-ingress branch is not up to date with the latest master :).

Hi there, please point the pull request onto master instead of fix-ingress branch. Also please rebase your branch onto master, since fix-ingress branch is not up to date with the latest master :).
skuethe commented 2020-12-04 11:31:29 +00:00 (Migrated from gitea.com)
Copy Link

Yeah that was probably a bad idea. Should have taken master in the first place, but was unsure what your policies are :)

I modified the PR to go into master - as my branch was created from master fork, this should "do it", right?

Yeah that was probably a bad idea. Should have taken master in the first place, but was unsure what your policies are :) I modified the PR to go into master - as my branch was created from master fork, this should "do it", right?
luhahn (Migrated from gitea.com) approved these changes 2020-12-07 08:58:33 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

Tested, looks good to me.Though i cannot test on Kubernetes 1.18 currently

Tested, looks good to me.Though i cannot test on Kubernetes 1.18 currently
luhahn commented 2020-12-08 08:34:30 +00:00 (Migrated from gitea.com)
Copy Link

Was tested on 1.18.6 as well

Was tested on 1.18.6 as well
lafriks (Migrated from gitea.com) approved these changes 2020-12-08 12:57:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
lafriks
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#78
No description provided.
Delete Branch "refs/pull/78/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?