lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Modifing LDAP settings doesn't re-deploy the gitea pod #99

New Issue
Closed
opened 2021-01-07 15:24:43 +00:00 by Skaronator · 2 comments
Skaronator commented 2021-01-07 15:24:43 +00:00 (Migrated from gitea.com)
Copy Link

I just modified my LDAP setting but nothing happends. Since LDAP settings are done in a init container it should re-deploy the existing pod.

We should add a checksum of the LDAP configuration to the Pod annotations:

https://gitea.com/gitea/helm-chart/src/branch/master/templates/gitea/statefulset.yaml#L16

I just modified my LDAP setting but nothing happends. Since LDAP settings are done in a init container it should re-deploy the existing pod. We should add a checksum of the LDAP configuration to the Pod annotations: https://gitea.com/gitea/helm-chart/src/branch/master/templates/gitea/statefulset.yaml#L16
👍 1
techknowlogick commented 2021-01-07 20:10:28 +00:00 (Migrated from gitea.com)
Copy Link

@Skaronator that sounds reasonable. Would you be open for a PR?

@Skaronator that sounds reasonable. Would you be open for a PR?
👍 1
Skaronator commented 2021-01-08 13:36:52 +00:00 (Migrated from gitea.com)
Copy Link

Not sure if I find time in the next few days but if I do I'll do a PR.

Not sure if I find time in the next few days but if I do I'll do a PR.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#99
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?