lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Add non-clustered redis as sub-chart #672

Merged
pat-s merged 20 commits from refs/pull/672/head into main 2024-07-07 09:57:17 +00:00
Conversation 1 Commits 20 Files Changed 11 +15 -1
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2b3f97a669 - Show all commits

2
Makefile
View File

@ -9,7 +9,7 @@ readme: prepare-environment
.PHONY: unittests
unittests:
helm unittest --strict -f 'unittests/**/*.yaml' -f 'unittests/dependency-major-image-check.yaml' ./
helm unittest --strict -f 'unittests/**/*.yaml' -f 'unittests/dependency-major-image-check.yaml' -f 'unittests/values-conflicting-checks.yaml' ./
justusbunsi commented 2024-07-05 19:19:24 +00:00 (Migrated from gitea.com)
Review
Copy Link

Thinking out loud:
There was a time when the unittest plugin didn't recognize the test files on root level when using that pattern. Nowadays this works. So in theory we could remove the 2nd and 3rd -f. But adding them will prevent possible regressions in the unittest plugin which would disable our checks. That's why I added the new file. :)

Thinking out loud: There was a time when the unittest plugin didn't recognize the test files on root level when using that pattern. Nowadays this works. So in theory we could remove the 2nd and 3rd `-f`. But adding them will prevent possible regressions in the unittest plugin which would disable our checks. That's why I added the new file. :)
.PHONY: helm
update-helm-dependencies:

14
unittests/values-conflicting-checks.yaml Normal file
View File

@ -0,0 +1,14 @@
suite: Values conflicting checks
release:
name: gitea-unittests
namespace: testing
tests:
- it: fails when trying to configure redis and redis-cluster the same time
set:
redis-cluster:
enabled: true
redis:
enabled: true
asserts:
- failedTemplate:
errorMessage: redis and redis-cluster cannot be enabled at the same time. Please only choose one.