phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Code examples for doc + fix Ncss ignoring asserts

Browse Source
This commit is contained in:
oowekyala
2017-08-07 17:08:40 +02:00
parent e9f4674f30
commit 02307ca8d5
3 changed files with 52 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/metrics/impl/visitors/DefaultNcssVisitor.java
View File

@ -7,6 +7,7 @@ package net.sourceforge.pmd.lang.java.metrics.impl.visitors;
import org.apache.commons.lang3.mutable.MutableInt;
import net.sourceforge.pmd.lang.java.ast.ASTAnnotationTypeDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTAssertStatement;
import net.sourceforge.pmd.lang.java.ast.ASTBreakStatement;
import net.sourceforge.pmd.lang.java.ast.ASTCatchStatement;
import net.sourceforge.pmd.lang.java.ast.ASTClassOrInterfaceDeclaration;
@ -220,4 +221,10 @@ public class DefaultNcssVisitor extends JavaParserVisitorAdapter {
return super.visit(node, data);
}
@Override
public Object visit(ASTAssertStatement node, Object data) {
((MutableInt) data).increment();
return super.visit(node, data);
}
}

9
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/metrics/impl/xml/NcssTest.xml
View File

@ -104,6 +104,7 @@
e.printStackTrace();
} catch (ThemAll pokemon) {
pokemon.train();
assert pokemon.level > 12;
} finally {
// Do nothing
}
@ -125,11 +126,11 @@
<rule-property name="reportClasses">true</rule-property>
<expected-problems>5</expected-problems>
<expected-messages>
<message>'com.company.money.Foo' has value 65 highest 20.</message>
<message>'com.company.money.Foo' has value 66 highest 21.</message>
<message>'com.company.money.Foo#Foo()' has value 2.</message>
<message>'com.company.money.Foo#Foo(int)' has value 13.</message>
<message>'com.company.money.Foo#foo()' has value 14.</message>
<message>'com.company.money.Foo#main(String)' has value 20.</message>
<message>'com.company.money.Foo#main(String)' has value 21.</message>
</expected-messages>
<code-ref id="full-example"/>
</test-code>
@ -140,11 +141,11 @@
<rule-property name="metricVersion">javaNcss</rule-property>
<expected-problems>5</expected-problems>
<expected-messages>
<message>'com.company.money.Foo' has value 68 highest 20.</message>
<message>'com.company.money.Foo' has value 69 highest 21.</message>
<message>'com.company.money.Foo#Foo()' has value 2.</message>
<message>'com.company.money.Foo#Foo(int)' has value 13.</message>
<message>'com.company.money.Foo#foo()' has value 14.</message>
<message>'com.company.money.Foo#main(String)' has value 20.</message>
<message>'com.company.money.Foo#main(String)' has value 21.</message>
</expected-messages>
<code-ref id="full-example"/>
</test-code>