phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'pr-111'

Browse Source
This commit is contained in:
Andreas Dangel
2016-10-29 17:24:40 +02:00
parent e7a68f4492 7d5be34cd2
commit 04257e657d
3 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/basic/BooleanInstantiationRule.java
View File

@ -3,6 +3,7 @@
*/
package net.sourceforge.pmd.lang.java.rule.basic;
import net.sourceforge.pmd.lang.ast.Node;
import net.sourceforge.pmd.lang.java.ast.ASTAllocationExpression;
import net.sourceforge.pmd.lang.java.ast.ASTArrayDimsAndInits;
import net.sourceforge.pmd.lang.java.ast.ASTBooleanLiteral;
@ -63,7 +64,9 @@ public class BooleanInstantiationRule extends AbstractJavaRule {
if (node.hasDescendantOfType(ASTArrayDimsAndInits.class)) {
return super.visit(node, data);
}
if (TypeHelper.isA((ASTClassOrInterfaceType) node.jjtGetChild(0), Boolean.class)) {
Node n1 = node.getFirstChildOfType(ASTClassOrInterfaceType.class);
if (TypeHelper.isA((ASTClassOrInterfaceType) n1, Boolean.class)) {
super.addViolation(data, node);
return data;
}

12
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/basic/xml/BooleanInstantiation.xml
View File

@ -158,4 +158,16 @@ public class Foo {
}
]]></code>
</test-code>
<test-code>
<description>#1533 [java] BooleanInstantiation: ClassCastException with Annotation</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Foo {
public void bar() {
Object o = new @Interned MyObject();
}
}
]]></code>
</test-code>
</test-data>