phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core] Deprecate RuleReference#getOverriddenLanguage() and #setLanguage()

Browse Source 
Refs #2742
This commit is contained in:
Andreas Dangel
2020-09-13 09:18:34 +02:00
parent dacfff1abf
commit 04592c8038
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/pages/release_notes.md
View File

@ -48,6 +48,8 @@ AbstractTokenizer and the custom tokenizers of Fortran, Perl and Ruby are deprec
* {% jdoc !!fortran::cpd.FortranTokenizer %}. Was replaced by an {% jdoc core::cpd.AnyTokenizer %}. Use {% jdoc !!fortran::cpd.FortranLanguage#getTokenizer() %} anyway. * {% jdoc !!fortran::cpd.FortranTokenizer %}. Was replaced by an {% jdoc core::cpd.AnyTokenizer %}. Use {% jdoc !!fortran::cpd.FortranLanguage#getTokenizer() %} anyway.
* {% jdoc !!perl::cpd.PerlTokenizer %}. Was replaced by an {% jdoc core::cpd.AnyTokenizer %}. Use {% jdoc !!perl::cpd.PerlLanguage#getTokenizer() %} anyway. * {% jdoc !!perl::cpd.PerlTokenizer %}. Was replaced by an {% jdoc core::cpd.AnyTokenizer %}. Use {% jdoc !!perl::cpd.PerlLanguage#getTokenizer() %} anyway.
* {% jdoc !!ruby::cpd.RubyTokenizer %}. Was replaced by an {% jdoc core::cpd.AnyTokenizer %}. Use {% jdoc !!ruby::cpd.RubyLanguage#getTokenizer() %} anyway. * {% jdoc !!ruby::cpd.RubyTokenizer %}. Was replaced by an {% jdoc core::cpd.AnyTokenizer %}. Use {% jdoc !!ruby::cpd.RubyLanguage#getTokenizer() %} anyway.
* {% jdoc !!core::lang.rule.RuleReference#getOverriddenLanguage() %} and
{% jdoc !!core::lang.rule.RuleReference#setLanguage(net.sourceforge.pmd.lang.Language) %}
### External Contributions ### External Contributions

8
pmd-core/src/main/java/net/sourceforge/pmd/lang/rule/RuleReference.java
View File

@ -85,13 +85,21 @@ public class RuleReference extends AbstractDelegateRule {
this.setRule(ref.getRule().deepCopy()); this.setRule(ref.getRule().deepCopy());
} }
/**
* @deprecated overriding the language of a rule is not supported.
*/
@Deprecated
public Language getOverriddenLanguage() { public Language getOverriddenLanguage() {
return language; return language;
} }
/**
* @deprecated overriding the language of a rule is not supported.
*/
// FIXME should we really allow overriding the language of a rule? // FIXME should we really allow overriding the language of a rule?
// I don't see any case where this wouldn't just make the rule fail during execution // I don't see any case where this wouldn't just make the rule fail during execution
@Override @Override
@Deprecated
public void setLanguage(Language language) { public void setLanguage(Language language) {
// Only override if different than current value, or if already // Only override if different than current value, or if already
// overridden. // overridden.