phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Java, typeres: add method applicability tests

Browse Source
This commit is contained in:
Bendegúz Nagy
2017-07-03 19:48:45 +02:00
parent 6652ec9545
commit 0c2099ab98
2 changed files with 64 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
pmd-java/src/test/java/net/sourceforge/pmd/typeresolution/ClassTypeResolverTest.java
View File

@ -16,6 +16,7 @@ import java.util.Comparator;
import java.util.List;
import java.util.StringTokenizer;
import net.sourceforge.pmd.typeresolution.testdata.MethodPotentialApplicability;
import org.apache.commons.io.IOUtils;
import org.jaxen.JaxenException;
import org.junit.Assert;
@ -1126,8 +1127,43 @@ public class ClassTypeResolverTest {
assertEquals(String.class, getChildType(expressions.get(index++), 3));
// this.field.first = "";
assertEquals(String.class, expressions.get(index).getType()); assertEquals(String.class, getChildType(expressions.get(index++), 2));
// Make sure we got them all
assertEquals("All expressions not tested", index, expressions.size());
}
@Test
public void testMethodPotentialApplicability() throws JaxenException {
ASTCompilationUnit acu = parseAndTypeResolveForClass15(MethodPotentialApplicability.class);
List<AbstractJavaTypeNode> expressions = convertList(
acu.findChildNodesWithXPath("//VariableInitializer/Expression/PrimaryExpression"),
AbstractJavaTypeNode.class);
int index = 0;
// int a = vararg("", "");
assertEquals(int.class, expressions.get(index).getType());
assertEquals(int.class, getChildType(expressions.get(index), 0));
assertEquals(int.class, getChildType(expressions.get(index++), 1));
// int b = vararg("", "", 10);
assertEquals(int.class, expressions.get(index).getType());
assertEquals(int.class, getChildType(expressions.get(index), 0));
assertEquals(int.class, getChildType(expressions.get(index++), 1));
// String c = notVararg(0, 0);
assertEquals(String.class, expressions.get(index).getType());
assertEquals(String.class, getChildType(expressions.get(index++), 2));
assertEquals(String.class, getChildType(expressions.get(index), 0));
assertEquals(String.class, getChildType(expressions.get(index++), 1));
// Number d = noArguments();
assertEquals(Number.class, expressions.get(index).getType());
assertEquals(Number.class, getChildType(expressions.get(index), 0));
assertEquals(Number.class, getChildType(expressions.get(index++), 1));
// Make sure we got them all
assertEquals("All expressions not tested", index, expressions.size());

27
pmd-java/src/test/java/net/sourceforge/pmd/typeresolution/testdata/MethodPotentialApplicability.java vendored Normal file
View File

@ -0,0 +1,27 @@
package net.sourceforge.pmd.typeresolution.testdata;
public class MethodPotentialApplicability {
void test() {
int a = vararg("", "");
int b = vararg("", "", 10);
String c = notVararg(0, 0);
Number d = noArguments();
// TODO: add test for: if there are type parameters then method is either non-generic or type arg airty matches
}
// test no arguments
Number noArguments() {return null;}
// test not vararg mathching arity
String notVararg(int a, int b) {return null;}
Exception notVararg(int a) {return null;}
// test if variable arity with arity n -> then call arity >= n-1
int vararg(String b, String c, int... a) { return 0;}
Exception vararg(int... b) {return null;}
}