phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core] Antlr - make more methods protected

Browse Source 
The abstract methods createPmdTerminal and createPmdError in AntlrGeneratedParserBase don't need to be public. They are just implementation.

The language specific inner nodes (KotlinInnerNode, SwiftInnerNode)
can be package private. Only the concrete subclasses are considered
public API.
This commit is contained in:
Andreas Dangel
2023-04-14 09:41:52 +02:00
parent ee227b1397
commit 0d5ecebd4e
9 changed files with 30 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pmd-kotlin/src/main/antlr4/net/sourceforge/pmd/lang/kotlin/ast/Kotlin.g4
View File

@ -15,12 +15,12 @@ import net.sourceforge.pmd.lang.ast.AstVisitor;
static final AntlrNameDictionary DICO = new KotlinNameDictionary(VOCABULARY, ruleNames);
@Override
public KotlinTerminalNode createPmdTerminal(ParserRuleContext parent, Token t) {
protected KotlinTerminalNode createPmdTerminal(ParserRuleContext parent, Token t) {
return new KotlinTerminalNode(t);
}
@Override
public KotlinErrorNode createPmdError(ParserRuleContext parent, Token t) {
protected KotlinErrorNode createPmdError(ParserRuleContext parent, Token t) {
return new KotlinErrorNode(t);
}
}

4
pmd-kotlin/src/main/antlr4/net/sourceforge/pmd/lang/kotlin/ast/README.md
View File

@ -50,12 +50,12 @@ import net.sourceforge.pmd.lang.ast.AstVisitor;
static final AntlrNameDictionary DICO = new KotlinNameDictionary(VOCABULARY, ruleNames);
@Override
public KotlinTerminalNode createPmdTerminal(ParserRuleContext parent, Token t) {
protected KotlinTerminalNode createPmdTerminal(ParserRuleContext parent, Token t) {
return new KotlinTerminalNode(t);
}
@Override
public KotlinErrorNode createPmdError(ParserRuleContext parent, Token t) {
protected KotlinErrorNode createPmdError(ParserRuleContext parent, Token t) {
return new KotlinErrorNode(t);
}
}

3
pmd-kotlin/src/main/java/net/sourceforge/pmd/lang/kotlin/ast/KotlinInnerNode.java
View File

@ -9,8 +9,7 @@ import org.antlr.v4.runtime.ParserRuleContext;
import net.sourceforge.pmd.lang.ast.AstVisitor;
import net.sourceforge.pmd.lang.ast.impl.antlr4.BaseAntlrInnerNode;
public abstract class KotlinInnerNode
extends BaseAntlrInnerNode<KotlinNode> implements KotlinNode {
abstract class KotlinInnerNode extends BaseAntlrInnerNode<KotlinNode> implements KotlinNode {
KotlinInnerNode(ParserRuleContext parent, int invokingStateNumber) {
super(parent, invokingStateNumber);