phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'master' into issue-1352

Browse Source
This commit is contained in:
Juan Martín Sotuyo Dodero
2018-09-22 03:23:15 -03:00
committed by GitHub
parent 15f99400be e30503b372
commit 10b100dded
10 changed files with 239 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pmd-java/src/main/resources/category/java/errorprone.xml
View File

@ -2303,6 +2303,7 @@ chain needs an own serialVersionUID field. See also [Should an abstract class ha
<value>
<![CDATA[
//ClassOrInterfaceDeclaration
[@Interface = 'false']
[count(ClassOrInterfaceBody/ClassOrInterfaceBodyDeclaration
/FieldDeclaration/VariableDeclarator/VariableDeclaratorId[@Image='serialVersionUID']) = 0]
[(ImplementsList | ExtendsList)/ClassOrInterfaceType[pmd-java:typeIs('java.io.Serializable')]]

9
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/MissingSerialVersionUID.xml
View File

@ -104,6 +104,15 @@ public class Foo implements Serializable {
package net.sourceforge.pmd.lang.java.rule.errorprone;
public class MissingSerialVersionUIDTest extends MissingSerialVersionUIDBase {
// ... no serialVersionUID value defined ...
}
]]></code>
</test-code>
<test-code>
<description>#1350 [java] MissingSerialVersionUID false-positive on interfaces</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public interface IDomainObject<ID extends Serializable & Comparable<? super ID>> extends MutablePrimaryIdentifier<ID>, Serializable {
}
]]></code>
</test-code>