Fix some pr comments

This commit is contained in:
Clément Fournier
2019-10-06 22:23:17 +02:00
parent ac9cc97313
commit 12d04beb9b
8 changed files with 0 additions and 59 deletions

View File

@ -11,7 +11,6 @@ import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler;
import net.sourceforge.pmd.lang.Parser; import net.sourceforge.pmd.lang.Parser;
import net.sourceforge.pmd.lang.ParserOptions; import net.sourceforge.pmd.lang.ParserOptions;
import net.sourceforge.pmd.lang.VisitorStarter; import net.sourceforge.pmd.lang.VisitorStarter;
import net.sourceforge.pmd.lang.XPathHandler;
import net.sourceforge.pmd.lang.apex.ast.ASTMethod; import net.sourceforge.pmd.lang.apex.ast.ASTMethod;
import net.sourceforge.pmd.lang.apex.ast.ASTUserClassOrInterface; import net.sourceforge.pmd.lang.apex.ast.ASTUserClassOrInterface;
import net.sourceforge.pmd.lang.apex.ast.ApexNode; import net.sourceforge.pmd.lang.apex.ast.ApexNode;
@ -20,7 +19,6 @@ import net.sourceforge.pmd.lang.apex.metrics.api.ApexClassMetricKey;
import net.sourceforge.pmd.lang.apex.metrics.api.ApexOperationMetricKey; import net.sourceforge.pmd.lang.apex.metrics.api.ApexOperationMetricKey;
import net.sourceforge.pmd.lang.apex.multifile.ApexMultifileVisitorFacade; import net.sourceforge.pmd.lang.apex.multifile.ApexMultifileVisitorFacade;
import net.sourceforge.pmd.lang.apex.rule.ApexRuleViolationFactory; import net.sourceforge.pmd.lang.apex.rule.ApexRuleViolationFactory;
import net.sourceforge.pmd.lang.ast.xpath.DefaultASTXPathHandler;
import net.sourceforge.pmd.lang.metrics.LanguageMetricsProvider; import net.sourceforge.pmd.lang.metrics.LanguageMetricsProvider;
import net.sourceforge.pmd.lang.metrics.internal.AbstractLanguageMetricsProvider; import net.sourceforge.pmd.lang.metrics.internal.AbstractLanguageMetricsProvider;
import net.sourceforge.pmd.lang.rule.RuleViolationFactory; import net.sourceforge.pmd.lang.rule.RuleViolationFactory;
@ -35,12 +33,6 @@ public class ApexHandler extends AbstractPmdLanguageVersionHandler {
return rootNode -> new ApexMultifileVisitorFacade().initializeWith((ApexNode<?>) rootNode); return rootNode -> new ApexMultifileVisitorFacade().initializeWith((ApexNode<?>) rootNode);
} }
@Override
public XPathHandler getXPathHandler() {
return new DefaultASTXPathHandler();
}
@Override @Override
public RuleViolationFactory getRuleViolationFactory() { public RuleViolationFactory getRuleViolationFactory() {
return ApexRuleViolationFactory.INSTANCE; return ApexRuleViolationFactory.INSTANCE;

View File

@ -4,7 +4,6 @@
package net.sourceforge.pmd.lang; package net.sourceforge.pmd.lang;
import net.sourceforge.pmd.lang.ast.xpath.DefaultASTXPathHandler;
import net.sourceforge.pmd.lang.dfa.DFAGraphRule; import net.sourceforge.pmd.lang.dfa.DFAGraphRule;
import net.sourceforge.pmd.lang.metrics.LanguageMetricsProvider; import net.sourceforge.pmd.lang.metrics.LanguageMetricsProvider;
@ -21,11 +20,6 @@ public abstract class AbstractLanguageVersionHandler implements LanguageVersionH
return DataFlowHandler.DUMMY; return DataFlowHandler.DUMMY;
} }
@Override
public XPathHandler getXPathHandler() {
return new DefaultASTXPathHandler();
}
@Override @Override
public ParserOptions getDefaultParserOptions() { public ParserOptions getDefaultParserOptions() {
return new ParserOptions(); return new ParserOptions();

View File

@ -7,8 +7,6 @@ package net.sourceforge.pmd.lang.jsp;
import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler; import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler;
import net.sourceforge.pmd.lang.Parser; import net.sourceforge.pmd.lang.Parser;
import net.sourceforge.pmd.lang.ParserOptions; import net.sourceforge.pmd.lang.ParserOptions;
import net.sourceforge.pmd.lang.XPathHandler;
import net.sourceforge.pmd.lang.ast.xpath.DefaultASTXPathHandler;
/** /**
* Implementation of LanguageVersionHandler for the JSP parser. * Implementation of LanguageVersionHandler for the JSP parser.
@ -17,12 +15,6 @@ import net.sourceforge.pmd.lang.ast.xpath.DefaultASTXPathHandler;
*/ */
public class JspHandler extends AbstractPmdLanguageVersionHandler { public class JspHandler extends AbstractPmdLanguageVersionHandler {
@Override
public XPathHandler getXPathHandler() {
return new DefaultASTXPathHandler();
}
@Override @Override
public Parser getParser(ParserOptions parserOptions) { public Parser getParser(ParserOptions parserOptions) {
return new JspParser(parserOptions); return new JspParser(parserOptions);

View File

@ -9,9 +9,7 @@ import net.sourceforge.pmd.lang.DataFlowHandler;
import net.sourceforge.pmd.lang.Parser; import net.sourceforge.pmd.lang.Parser;
import net.sourceforge.pmd.lang.ParserOptions; import net.sourceforge.pmd.lang.ParserOptions;
import net.sourceforge.pmd.lang.VisitorStarter; import net.sourceforge.pmd.lang.VisitorStarter;
import net.sourceforge.pmd.lang.XPathHandler;
import net.sourceforge.pmd.lang.ast.Node; import net.sourceforge.pmd.lang.ast.Node;
import net.sourceforge.pmd.lang.ast.xpath.DefaultASTXPathHandler;
import net.sourceforge.pmd.lang.dfa.DFAGraphRule; import net.sourceforge.pmd.lang.dfa.DFAGraphRule;
import net.sourceforge.pmd.lang.plsql.ast.ASTInput; import net.sourceforge.pmd.lang.plsql.ast.ASTInput;
import net.sourceforge.pmd.lang.plsql.dfa.DFAPLSQLGraphRule; import net.sourceforge.pmd.lang.plsql.dfa.DFAPLSQLGraphRule;
@ -66,11 +64,4 @@ public class PLSQLHandler extends AbstractPmdLanguageVersionHandler {
}; };
} }
/**
* Return minimal XPathHandler to cope with Jaxen XPath Rules.
*/
@Override
public XPathHandler getXPathHandler() {
return new DefaultASTXPathHandler();
}
} }

View File

@ -7,16 +7,9 @@ package net.sourceforge.pmd.lang.swift;
import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler; import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler;
import net.sourceforge.pmd.lang.Parser; import net.sourceforge.pmd.lang.Parser;
import net.sourceforge.pmd.lang.ParserOptions; import net.sourceforge.pmd.lang.ParserOptions;
import net.sourceforge.pmd.lang.XPathHandler;
import net.sourceforge.pmd.lang.ast.xpath.DefaultASTXPathHandler;
public class SwiftHandler extends AbstractPmdLanguageVersionHandler { public class SwiftHandler extends AbstractPmdLanguageVersionHandler {
@Override
public XPathHandler getXPathHandler() {
return new DefaultASTXPathHandler();
}
@Override @Override
public Parser getParser(final ParserOptions parserOptions) { public Parser getParser(final ParserOptions parserOptions) {
return new SwiftParserAdapter(parserOptions); return new SwiftParserAdapter(parserOptions);

View File

@ -7,16 +7,9 @@ package net.sourceforge.pmd.lang.vf;
import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler; import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler;
import net.sourceforge.pmd.lang.Parser; import net.sourceforge.pmd.lang.Parser;
import net.sourceforge.pmd.lang.ParserOptions; import net.sourceforge.pmd.lang.ParserOptions;
import net.sourceforge.pmd.lang.XPathHandler;
import net.sourceforge.pmd.lang.ast.xpath.DefaultASTXPathHandler;
public class VfHandler extends AbstractPmdLanguageVersionHandler { public class VfHandler extends AbstractPmdLanguageVersionHandler {
@Override
public XPathHandler getXPathHandler() {
return new DefaultASTXPathHandler();
}
@Override @Override
public Parser getParser(ParserOptions parserOptions) { public Parser getParser(ParserOptions parserOptions) {
return new VfParser(parserOptions); return new VfParser(parserOptions);

View File

@ -7,8 +7,6 @@ package net.sourceforge.pmd.lang.vm;
import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler; import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler;
import net.sourceforge.pmd.lang.Parser; import net.sourceforge.pmd.lang.Parser;
import net.sourceforge.pmd.lang.ParserOptions; import net.sourceforge.pmd.lang.ParserOptions;
import net.sourceforge.pmd.lang.XPathHandler;
import net.sourceforge.pmd.lang.ast.xpath.DefaultASTXPathHandler;
/** /**
* Implementation of LanguageVersionHandler for the VM parser. * Implementation of LanguageVersionHandler for the VM parser.
@ -16,11 +14,6 @@ import net.sourceforge.pmd.lang.ast.xpath.DefaultASTXPathHandler;
*/ */
public class VmHandler extends AbstractPmdLanguageVersionHandler { public class VmHandler extends AbstractPmdLanguageVersionHandler {
@Override
public XPathHandler getXPathHandler() {
return new DefaultASTXPathHandler();
}
@Override @Override
public Parser getParser(final ParserOptions parserOptions) { public Parser getParser(final ParserOptions parserOptions) {

View File

@ -7,19 +7,12 @@ package net.sourceforge.pmd.lang.xml;
import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler; import net.sourceforge.pmd.lang.AbstractPmdLanguageVersionHandler;
import net.sourceforge.pmd.lang.Parser; import net.sourceforge.pmd.lang.Parser;
import net.sourceforge.pmd.lang.ParserOptions; import net.sourceforge.pmd.lang.ParserOptions;
import net.sourceforge.pmd.lang.XPathHandler;
import net.sourceforge.pmd.lang.ast.xpath.DefaultASTXPathHandler;
/** /**
* Implementation of LanguageVersionHandler for the XML. * Implementation of LanguageVersionHandler for the XML.
*/ */
public class XmlHandler extends AbstractPmdLanguageVersionHandler { public class XmlHandler extends AbstractPmdLanguageVersionHandler {
@Override
public XPathHandler getXPathHandler() {
return new DefaultASTXPathHandler();
}
@Override @Override
public ParserOptions getDefaultParserOptions() { public ParserOptions getDefaultParserOptions() {
return new XmlParserOptions(); return new XmlParserOptions();