phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[plsql] Add test for TooManyMethods and fix the rule

Browse Source
This commit is contained in:
Andreas Dangel
2019-03-18 20:06:44 +01:00
parent ba31b0ce9f
commit 14ad94340c
3 changed files with 110 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pmd-plsql/src/main/resources/category/plsql/design.xml
View File

@ -512,22 +512,22 @@ have more fine grained objects.
( (
count(/descendant::ProgramUnit[ count(/descendant::ProgramUnit[
not ( not (
starts-with(@Image,'get') starts-with(@Name,'get')
or or
starts-with(@Image,'set') starts-with(@Name,'set')
or or
starts-with(@Image,'is') starts-with(@Name,'is')
) )
] ]
) )
+ +
count(/descendant::TypeMethod[ count(/descendant::TypeMethod[
not ( not (
starts-with(@Image,'get') starts-with(@Name,'get')
or or
starts-with(@Image,'set') starts-with(@Name,'set')
or or
starts-with(@Image,'is') starts-with(@Name,'is')
) )
] ]
) )

11
pmd-plsql/src/test/java/net/sourceforge/pmd/lang/plsql/rule/design/TooManyMethodsTest.java Normal file
View File

@ -0,0 +1,11 @@
/**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.plsql.rule.design;
import net.sourceforge.pmd.testframework.PmdRuleTst;
public class TooManyMethodsTest extends PmdRuleTst {
// no additional unit tests
}

93
pmd-plsql/src/test/resources/net/sourceforge/pmd/lang/plsql/rule/design/xml/TooManyMethods.xml Normal file
View File

@ -0,0 +1,93 @@
<?xml version="1.0" encoding="UTF-8"?>
<test-data
xmlns="http://pmd.sourceforge.net/rule-tests"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sourceforge.net/rule-tests http://pmd.sourceforge.net/rule-tests_1_0_0.xsd">
<test-code>
<description>Too many methods in a package</description>
<rule-property name="maxmethods">3</rule-property>
<expected-problems>1</expected-problems>
<code>
<![CDATA[
CREATE OR REPLACE PACKAGE update_planned_hrs
IS
PROCEDURE method1 (id IN NUMBER);
PROCEDURE method2 (id IN NUMBER);
PROCEDURE method3 (id IN NUMBER);
PROCEDURE method4 (id IN NUMBER);
FUNCTION getId1() RETURN NUMBER;
FUNCTION getId2() RETURN NUMBER;
FUNCTION getId3() RETURN NUMBER;
FUNCTION getId4() RETURN NUMBER;
END update_planned_hrs;
/
]]>
</code>
<source-type>plsql</source-type>
</test-code>
<test-code>
<description>Getters are ignored</description>
<rule-property name="maxmethods">3</rule-property>
<expected-problems>0</expected-problems>
<code>
<![CDATA[
CREATE OR REPLACE PACKAGE update_planned_hrs
IS
PROCEDURE method1 (id IN NUMBER);
PROCEDURE method2 (id IN NUMBER);
PROCEDURE method3 (id IN NUMBER);
FUNCTION getId1() RETURN NUMBER;
FUNCTION isId2() RETURN BOOL;
FUNCTION getId3() RETURN NUMBER;
FUNCTION getId4() RETURN NUMBER;
END update_planned_hrs;
/
]]>
</code>
<source-type>plsql</source-type>
</test-code>
<test-code>
<description>Too many methods in a type definition</description>
<rule-property name="maxmethods">3</rule-property>
<expected-problems>1</expected-problems>
<code>
<![CDATA[
CREATE TYPE data_typ1 AS OBJECT
( year NUMBER,
MEMBER FUNCTION prod1(invent NUMBER) RETURN NUMBER,
MEMBER FUNCTION prod2(invent NUMBER) RETURN NUMBER,
MEMBER FUNCTION prod3(invent NUMBER) RETURN NUMBER,
MEMBER FUNCTION prod4(invent NUMBER) RETURN NUMBER,
MEMBER FUNCTION prod5(invent NUMBER) RETURN NUMBER
);
/
]]>
</code>
<source-type>plsql</source-type>
</test-code>
<test-code>
<description>Getters/Setters are ignored for types</description>
<rule-property name="maxmethods">3</rule-property>
<expected-problems>0</expected-problems>
<code>
<![CDATA[
CREATE TYPE data_typ1 AS OBJECT
( year NUMBER,
MEMBER FUNCTION prod1(invent NUMBER) RETURN NUMBER,
MEMBER FUNCTION prod2(invent NUMBER) RETURN NUMBER,
MEMBER FUNCTION prod3(invent NUMBER) RETURN NUMBER,
MEMBER FUNCTION getProd(invent NUMBER) RETURN NUMBER,
MEMBER PROCEDURE setProd(invent NUMBER)
);
/
]]>
</code>
<source-type>plsql</source-type>
</test-code>
</test-data>