phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

InefficientEmptyStringCheck: Fix NPE

Browse Source
This commit is contained in:
Andreas Dangel
2017-03-27 21:55:38 +02:00
parent 076a108ee0
commit 19ee0cd37b
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/strings/InefficientEmptyStringCheckRule.java
View File

@ -56,7 +56,7 @@ public class InefficientEmptyStringCheckRule extends AbstractInefficientZeroChec
Node prevCall = node.jjtGetChild(node.jjtGetNumChildren() - 4); Node prevCall = node.jjtGetChild(node.jjtGetNumChildren() - 4);
String target = prevCall.jjtGetNumChildren() > 0 ? prevCall.jjtGetChild(0).getImage() : prevCall.getImage(); String target = prevCall.jjtGetNumChildren() > 0 ? prevCall.jjtGetChild(0).getImage() : prevCall.getImage();
if (target != null && "trim".equals(target) || target.endsWith(".trim")) { if (target != null && ("trim".equals(target) || target.endsWith(".trim"))) {
addViolation(data, node); addViolation(data, node);
} }
} }

15
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/strings/xml/InefficientEmptyStringCheck.xml
View File

@ -179,5 +179,18 @@ public class Foo {
} }
]]></code> ]]></code>
</test-code> </test-code>
<test-code>
<description>Verify no NPE is thrown</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Foo {
void bar() {
if (super.guardStmtByLogLevel.isEmpty() && logLevels.length > 0 && guardMethods.length > 0) {
configureGuards(logLevels, guardMethods);
}
}
}
]]></code>
</test-code>
</test-data> </test-data>