phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use JUnit's TemporaryFolder rule

Browse Source 
Don't reinvent the wheel. TemporaryFolder already takes care of cleaning
up the created files.
This commit is contained in:
Stefan Birkner
2020-09-30 22:30:24 +02:00
parent d5729e65dc
commit 22db2fdebc
10 changed files with 55 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pmd-java/src/test/java/net/sourceforge/pmd/coverage/PMDCoverageTest.java
View File

@ -18,6 +18,7 @@ import org.junit.Rule;
import org.junit.Test;
import org.junit.contrib.java.lang.system.StandardErrorStreamLog;
import org.junit.contrib.java.lang.system.StandardOutputStreamLog;
import org.junit.rules.TemporaryFolder;
import net.sourceforge.pmd.PMD;
@ -29,6 +30,9 @@ public class PMDCoverageTest {
@Rule
public StandardErrorStreamLog errorStream = new StandardErrorStreamLog();
@Rule
public TemporaryFolder folder = new TemporaryFolder();
/**
* Test some of the PMD command line options
*/
@ -46,9 +50,8 @@ public class PMDCoverageTest {
String[] args;
args = commandLine.split("\\s");
File f = null;
try {
f = File.createTempFile("pmd", ".txt");
File f = folder.newFile();
int n = args.length;
String[] a = new String[n + 2 + 2];
System.arraycopy(args, 0, a, 0, n);
@ -74,10 +77,6 @@ public class PMDCoverageTest {
assertEquals("No parsing error expected", 0, StringUtils.countMatches(report, "Error while parsing"));
} catch (IOException ioe) {
fail("Problem creating temporary file: " + ioe.getLocalizedMessage());
} finally {
if (f != null) {
f.delete();
}
}
}