Deprecate Rulechain visitors

pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/ApexRuleChainVisitor.java

@@ -16,6 +16,7 @@ import net.sourceforge.pmd.lang.ast.Node;
 import net.sourceforge.pmd.lang.rule.AbstractRuleChainVisitor;
 import net.sourceforge.pmd.lang.rule.XPathRule;
 
+@Deprecated
 public class ApexRuleChainVisitor extends AbstractRuleChainVisitor {
 
     @Override

pmd-core/src/main/java/net/sourceforge/pmd/lang/Language.java

@@ -77,7 +77,10 @@ public interface Language extends Comparable<Language> {
      *
      * @return The RuleChainVisitor class.
      * @see net.sourceforge.pmd.lang.rule.RuleChainVisitor
+     *
+     * @deprecated Will be removed in PMD 7, avoid using this
      */
+    @Deprecated
     Class<?> getRuleChainVisitorClass();
 
     /**

pmd-core/src/main/java/net/sourceforge/pmd/lang/rule/AbstractRuleChainVisitor.java

@@ -28,7 +28,10 @@ import net.sourceforge.pmd.lang.ast.Node;
  * This is a base class for RuleChainVisitor implementations which extracts
  * interesting nodes from an AST, and lets each Rule visit the nodes it has
  * expressed interest in.
+ *
+ * @deprecated See {@link RuleChainVisitor}
  */
+@Deprecated
 public abstract class AbstractRuleChainVisitor implements RuleChainVisitor {
     private static final Logger LOG = Logger.getLogger(AbstractRuleChainVisitor.class.getName());
 

pmd-core/src/main/java/net/sourceforge/pmd/lang/rule/RuleChainVisitor.java

@@ -9,12 +9,18 @@ import java.util.List;
 import net.sourceforge.pmd.Rule;
 import net.sourceforge.pmd.RuleContext;
 import net.sourceforge.pmd.RuleSet;
+import net.sourceforge.pmd.lang.BaseLanguageModule;
 import net.sourceforge.pmd.lang.ast.Node;
 
 /**
  * The RuleChainVisitor understands how to visit an AST for a particular
  * Language.
+ *
+ * @deprecated This interface will be removed. It's only used in internal
+ *      code. Language implementors no longer need to register a rulechain
+ *      visitor implementation in the {@link BaseLanguageModule} constructor.
  */
+@Deprecated
 public interface RuleChainVisitor {
     /**
      * Add the given rule to the visitor.

pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/JavaRuleChainVisitor.java

@@ -16,6 +16,7 @@ import net.sourceforge.pmd.lang.java.ast.JavaParserVisitorAdapter;
 import net.sourceforge.pmd.lang.rule.AbstractRuleChainVisitor;
 import net.sourceforge.pmd.lang.rule.XPathRule;
 
+@Deprecated
 public class JavaRuleChainVisitor extends AbstractRuleChainVisitor {
 
     @Override

pmd-javascript/src/main/java/net/sourceforge/pmd/lang/ecmascript/rule/EcmascriptRuleChainVisitor.java

@@ -16,6 +16,7 @@ import net.sourceforge.pmd.lang.ecmascript.ast.EcmascriptParserVisitor;
 import net.sourceforge.pmd.lang.rule.AbstractRuleChainVisitor;
 import net.sourceforge.pmd.lang.rule.XPathRule;
 
+@Deprecated
 public class EcmascriptRuleChainVisitor extends AbstractRuleChainVisitor {
 
     @Override

pmd-jsp/src/main/java/net/sourceforge/pmd/lang/jsp/rule/JspRuleChainVisitor.java

@@ -16,6 +16,7 @@ import net.sourceforge.pmd.lang.jsp.ast.JspParserVisitorAdapter;
 import net.sourceforge.pmd.lang.rule.AbstractRuleChainVisitor;
 import net.sourceforge.pmd.lang.rule.XPathRule;
 
+@Deprecated
 public class JspRuleChainVisitor extends AbstractRuleChainVisitor {
 
     @Override

pmd-modelica/src/main/java/net/sourceforge/pmd/lang/modelica/rule/ModelicaRuleChainVisitor.java

@@ -16,6 +16,7 @@ import net.sourceforge.pmd.lang.modelica.ast.ModelicaParserVisitorAdapter;
 import net.sourceforge.pmd.lang.rule.AbstractRuleChainVisitor;
 import net.sourceforge.pmd.lang.rule.XPathRule;
 
+@Deprecated
 public class ModelicaRuleChainVisitor extends AbstractRuleChainVisitor {
     @Override
     protected void visit(Rule rule, Node node, RuleContext ctx) {

pmd-plsql/src/main/java/net/sourceforge/pmd/lang/plsql/rule/PLSQLRuleChainVisitor.java

@@ -18,6 +18,7 @@ import net.sourceforge.pmd.lang.plsql.ast.PLSQLParserVisitorAdapter;
 import net.sourceforge.pmd.lang.rule.AbstractRuleChainVisitor;
 import net.sourceforge.pmd.lang.rule.XPathRule;
 
+@Deprecated
 public class PLSQLRuleChainVisitor extends AbstractRuleChainVisitor {
     private static final Logger LOGGER = Logger.getLogger(PLSQLRuleChainVisitor.class.getName());
     private static final String CLASS_NAME = PLSQLRuleChainVisitor.class.getName();

pmd-scala-modules/pmd-scala-common/src/main/java/net/sourceforge/pmd/lang/scala/rule/ScalaRuleChainVisitor.java

@@ -19,6 +19,7 @@ import net.sourceforge.pmd.lang.scala.ast.ScalaParserVisitorAdapter;
 /**
  * A Rule Chain visitor for Scala.
  */
+@Deprecated
 public class ScalaRuleChainVisitor extends AbstractRuleChainVisitor {
 
     @SuppressWarnings("unchecked")

pmd-test/src/main/java/net/sourceforge/pmd/test/lang/DummyLanguageModule.java

@@ -48,6 +48,7 @@ public class DummyLanguageModule extends BaseLanguageModule {
         addVersion("1.8", new Handler(), false);
     }
 
+    @Deprecated
     public static class DummyRuleChainVisitor extends AbstractRuleChainVisitor {
         @Override
         protected void visit(Rule rule, Node node, RuleContext ctx) {

pmd-visualforce/src/main/java/net/sourceforge/pmd/lang/vf/rule/VfRuleChainVisitor.java

@@ -16,6 +16,7 @@ import net.sourceforge.pmd.lang.vf.ast.VfNode;
 import net.sourceforge.pmd.lang.vf.ast.VfParserVisitor;
 import net.sourceforge.pmd.lang.vf.ast.VfParserVisitorAdapter;
 
+@Deprecated
 public class VfRuleChainVisitor extends AbstractRuleChainVisitor {
 
     @Override

pmd-vm/src/main/java/net/sourceforge/pmd/lang/vm/rule/VmRuleChainVisitor.java

@@ -17,6 +17,7 @@ import net.sourceforge.pmd.lang.vm.ast.VmNode;
 import net.sourceforge.pmd.lang.vm.ast.VmParserVisitor;
 import net.sourceforge.pmd.lang.vm.ast.VmParserVisitorAdapter;
 
+@Deprecated
 public class VmRuleChainVisitor extends AbstractRuleChainVisitor {
 
     @Override

pmd-xml/src/main/java/net/sourceforge/pmd/lang/xml/rule/XmlRuleChainVisitor.java

@@ -14,6 +14,7 @@ import net.sourceforge.pmd.lang.ast.Node;
 import net.sourceforge.pmd.lang.rule.AbstractRuleChainVisitor;
 import net.sourceforge.pmd.lang.rule.XPathRule;
 
+@Deprecated
 public class XmlRuleChainVisitor extends AbstractRuleChainVisitor {
 
     @Override