phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'pr-2010'

Browse Source
This commit is contained in:
Andreas Dangel
2019-10-05 18:28:48 +02:00
parent 7f936e3c38 06add3a5a7
commit 5156e8922e
3 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/design/LawOfDemeterRule.java
View File

@ -168,7 +168,8 @@ public class LawOfDemeterRule extends AbstractJavaRule {
private boolean isNotBuilder() {
return baseType != StringBuffer.class && baseType != StringBuilder.class
&& !"StringBuilder".equals(baseTypeName) && !"StringBuffer".equals(baseTypeName);
&& !"StringBuilder".equals(baseTypeName) && !"StringBuffer".equals(baseTypeName)
&& !methodName.endsWith("Builder");
}
private static List<ASTPrimarySuffix> findSuffixesWithoutArguments(ASTPrimaryExpression expr) {

14
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/LawOfDemeter.xml
View File

@ -269,6 +269,20 @@ public class Test {
final FooBuilder fooBuilder = FooBuilder.newBuilder();
fooBuilder.withBar();
}
}
]]></code>
</test-code>
<test-code>
<description>#2010 False Positive for Law of Demeter</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Test {
public void bar() {
// Inner Builder pattern chained
final Bar bar = Bar.newBuilder()
.withFoo("foo")
.build();
}
}
]]></code>
</test-code>