phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Definitely fix swift impl

Browse Source
This commit is contained in:
Clément Fournier
2020-01-17 14:01:20 +01:00
parent db424fc1e6
commit 53b2b4f201
4 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pmd-core/src/main/java/net/sourceforge/pmd/lang/ast/Node.java
View File

@ -67,7 +67,7 @@ public interface Node {
*/ */
@Deprecated @Deprecated
default void jjtOpen() { default void jjtOpen() {
// do nothing
} }
@ -78,7 +78,7 @@ public interface Node {
*/ */
@Deprecated @Deprecated
default void jjtClose() { default void jjtClose() {
// do nothing
} }

2
pmd-swift/src/main/antlr4/net/sourceforge/pmd/lang/swift/ast/Swift.g4
View File

@ -55,7 +55,7 @@ import net.sourceforge.pmd.lang.ast.impl.antlr4.*;
options { options {
contextSuperClass = AntlrBaseNode; contextSuperClass = AntlrBaseNode;
superClass = PmdBaseAntlrParser; superClass = PmdAntlrParserBase;
} }
topLevel : statements? EOF ; topLevel : statements? EOF ;

2
pmd-swift/src/main/resources/category/swift/bestpractices.xml
View File

@ -11,6 +11,7 @@ Rules which enforce generally accepted best practices.
<rule name="ProhibitedInterfaceBuilder" <rule name="ProhibitedInterfaceBuilder"
since="7.0" since="7.0"
language="swift"
message="Creating views using Interface Builder should be avoided." message="Creating views using Interface Builder should be avoided."
class="net.sourceforge.pmd.lang.swift.rule.bestpractices.ProhibitedInterfaceBuilderRule" class="net.sourceforge.pmd.lang.swift.rule.bestpractices.ProhibitedInterfaceBuilderRule"
externalInfoUrl="http://pmd.github.io/pmd/pmd_rules_swift_bestpractices.html#prohibitedinterfacebuilder"> externalInfoUrl="http://pmd.github.io/pmd/pmd_rules_swift_bestpractices.html#prohibitedinterfacebuilder">
@ -36,6 +37,7 @@ class ViewController: UIViewController {
<rule name="UnavailableFunction" <rule name="UnavailableFunction"
since="7.0" since="7.0"
language="swift"
message="Unimplemented functions should be marked as unavailable." message="Unimplemented functions should be marked as unavailable."
class="net.sourceforge.pmd.lang.swift.rule.bestpractices.UnavailableFunctionRule" class="net.sourceforge.pmd.lang.swift.rule.bestpractices.UnavailableFunctionRule"
externalInfoUrl="http://pmd.github.io/pmd/pmd_rules_swift_bestpractices.html#unavailablefunction"> externalInfoUrl="http://pmd.github.io/pmd/pmd_rules_swift_bestpractices.html#unavailablefunction">