phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Corrections from PR #1032

Browse Source
This commit is contained in:
Andreas Dangel
2018-04-10 17:29:23 +02:00
parent b720210723
commit 5fa3167868
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pmd-java/src/main/resources/category/java/performance.xml
View File

@@ -208,13 +208,15 @@ adverse impacts on performance.
<![CDATA[
//FieldDeclaration/Type/PrimitiveType[@Image = 'short']
|
//ClassOrInterfaceBodyDeclaration[not(Annotation/MarkerAnnotation/Name[@Image='Override'])]
//ClassOrInterfaceBodyDeclaration[not(Annotation/MarkerAnnotation/Name[typeof(@Image, 'java.lang.Override', 'Override')])]
/MethodDeclaration/ResultType/Type/PrimitiveType[@Image = 'short']
|
//ClassOrInterfaceBodyDeclaration[not(Annotation/MarkerAnnotation/Name[@Image='Override'])]
//ClassOrInterfaceBodyDeclaration[not(Annotation/MarkerAnnotation/Name[typeof(@Image, 'java.lang.Override', 'Override')])]
/MethodDeclaration/MethodDeclarator/FormalParameters/FormalParameter/Type/PrimitiveType[@Image = 'short']
|
//LocalVariableDeclaration/Type/PrimitiveType[@Image = 'short']
|
//AnnotationMethodDeclaration/Type/PrimitiveType[@Image = 'short']
]]>
</value>
</property>

10
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/AvoidUsingShortType.xml
View File

@@ -133,6 +133,16 @@ public class ShortTest implements NodeFilter {
public short acceptNode(@Nullable Node node) {
return 0;
}
}
]]></code>
</test-code>
<test-code>
<description>short as annotation property</description>
<expected-problems>1</expected-problems>
<code><![CDATA[
public @interface MyAnnotation {
short dontUseShort();
}
]]></code>
</test-code>