phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve test, cover cases whith no rule / assert

Browse Source
This commit is contained in:
Juan Martín Sotuyo Dodero
2017-03-26 23:27:22 -03:00
parent 493e289200
commit 6458883a61
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/junit/xml/JUnitTestsShouldIncludeAssert.xml
View File

@ -273,26 +273,26 @@ public class Foo_Test
</test-code>
<test-code>
<description>#285 Issues with @Rule annotation and ExpectedException</description>
<expected-problems>0</expected-problems>
<expected-problems>1</expected-problems>
<expected-linenumbers>7</expected-linenumbers>
<code><![CDATA[
import org.junit.*;
public class SimpleExpectedExceptionTest {
@Rule
public ExpectedException thrown = ExpectedException.none();
@Rule
public ExpectedException thrown = ExpectedException.none();
@Test
public void throwsExceptionWithSpecificType() {
thrown.expect(NullPointerException.class);
throw new NullPointerException();
}
@Test
public void throwsExceptionWithSpecificType() {
throw new NullPointerException(); // No expect! this is a violation
}
@Test
public void throwsIllegalArgumentExceptionIfIconIsNull() {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("Icon is null, not a file, or doesn't exist.");
new DigitalAssetManager(null, null);
}
}
@Test
public void throwsIllegalArgumentExceptionIfIconIsNull() {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("Icon is null, not a file, or doesn't exist.");
new DigitalAssetManager(null, null);
}
}
]]></code>
</test-code>
<test-code>