phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix dogfood - ReturnEmptyCollectionRatherThanNull

Browse Source
This commit is contained in:
Andreas Dangel
2022-01-09 20:46:45 +01:00
parent 964083319e
commit 65b4ba58a7
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pmd-core/src/main/java/net/sourceforge/pmd/dcd/asm/TypeSignatureVisitor.java
View File

@ -98,11 +98,7 @@ public class TypeSignatureVisitor extends SignatureVisitor {
if (parameterTypes == null) { if (parameterTypes == null) {
throw new RuntimeException(); throw new RuntimeException();
} }
if (parameterTypes != null) { return parameterTypes.toArray(new Class<?>[0]);
return parameterTypes.toArray(new Class<?>[0]);
} else {
return null;
}
} }
private void pushType(int type) { private void pushType(int type) {

3
pmd-core/src/main/java/net/sourceforge/pmd/util/database/DBMSMetadata.java
View File

@ -15,6 +15,7 @@ import java.sql.ResultSet;
import java.sql.SQLException; import java.sql.SQLException;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collections;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Properties; import java.util.Properties;
@ -302,7 +303,7 @@ public class DBMSMetadata {
if (null == dburi) { if (null == dburi) {
LOGGER.warning("No dbUri defined - no further action possible"); LOGGER.warning("No dbUri defined - no further action possible");
return null; return Collections.emptyList();
} else { } else {
return getSourceObjectList(dburi.getLanguagesList(), dburi.getSchemasList(), dburi.getSourceCodeTypesList(), return getSourceObjectList(dburi.getLanguagesList(), dburi.getSchemasList(), dburi.getSourceCodeTypesList(),
dburi.getSourceCodeNamesList()); dburi.getSourceCodeNamesList());