phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #3347 from adangel:issue-3340-guardlogstatement

Browse Source 
[java] NullPointerException applying rule GuardLogStatement #3347
This commit is contained in:
Andreas Dangel
2021-06-24 14:42:53 +02:00
parent 1e1fcf5c8b b24e2edd25
commit 7260e8806c
3 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/bestpractices/GuardLogStatementRule.java
View File

@ -203,7 +203,7 @@ public class GuardLogStatementRule extends AbstractJavaRule implements Rule {
}
private boolean hasArgumentWithMethodCall(ASTPrimarySuffix node) {
if (!node.isArguments()) {
if (!node.isArguments() || node.getArgumentCount() <= 0) {
return false;
}

14
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/GuardLogStatement.xml
View File

@ -538,6 +538,20 @@ public class Logger {
});
runTestLambda((s1, s2) -> {LOGGER.debug(s1 + s2);});
}
}
]]></code>
</test-code>
<test-code>
<description>NullPointerException applying rule GuardLogStatement (#3340)</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Logger {
private static final Logger LOGGER = new Logger();
public void bar() {
LOGGER.debug();
}
}
]]></code>
</test-code>