phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify nested loop

Browse Source
This commit is contained in:
YoonhoChoi96
2019-07-17 19:49:08 +09:00
parent 24cb0aa976
commit 82ea3ed51b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/dfa/VariableAccessVisitor.java
View File

@ -103,21 +103,21 @@ public class VariableAccessVisitor extends JavaParserVisitorAdapter {
for (Node temp = name.getLocation(); !(temp.jjtGetParent() instanceof ASTMethodDeclaration)
&& !(temp.jjtGetParent() instanceof ASTConstructorDeclaration); temp = temp.jjtGetParent()) {
//traverse children nodes to check it has assignment operator as a child
for (int i = 0; i < temp.jjtGetNumChildren(); i++) {
if (temp.jjtGetChild(i) instanceof ASTAssignmentOperator) {
List<ASTAssignmentOperator> assignmentOperators = temp.findChildrenOfType(ASTAssignmentOperator.class);
if (!assignmentOperators.isEmpty()) {
//if assignment operator is found, add to arraylist(assignments) with the assignment operator and its name
assignments.add(new SimpleEntry(temp.jjtGetChild(i), name));
assignments.add(new SimpleEntry(assignmentOperators.get(0), name));
//change flag
flag = 1;
break checker;
}
}
}
//if a name is not related to assignment operator, add to arraylist(assignments) with null and its name
if (flag == 0) {
assignments.add(new SimpleEntry(null, name));
}
}
//swap the arraylist(assignments)'s elements, when it share same assignment operator
for (int i = 0; i < assignments.size() - 1; i++) {
if (assignments.get(i).getKey() != null