phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use explicit encoding in ruleset files

Browse Source
This commit is contained in:
Andreas Dangel
2023-06-01 17:29:24 +02:00
parent e6428eb6fd
commit 8a89a4c786
119 changed files with 171 additions and 128 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pmd-apex/src/main/resources/category/apex/bestpractices.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Best Practices"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/codestyle.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Code Style"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/design.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Design"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/documentation.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Documentation"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/errorprone.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Error Prone"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/multithreading.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Multithreading"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/performance.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Performance"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/security.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Security"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

9
pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/DefaultRulesetTest.java
View File

@ -9,12 +9,14 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test;
import net.sourceforge.pmd.AbstractRuleSetFactoryTest;
import net.sourceforge.pmd.RuleSet;
import net.sourceforge.pmd.RuleSetLoader;
import com.github.stefanbirkner.systemlambda.SystemLambda;
class DefaultRulesetTest {
private static final String QUICKSTART_RULESET = "rulesets/apex/quickstart.xml";
@Test
void loadDefaultRuleset() {
@ -25,12 +27,17 @@ class DefaultRulesetTest {
@Test
void loadQuickstartRuleset() throws Exception {
String log = SystemLambda.tapSystemErr(() -> {
RuleSet ruleset = rulesetLoader().loadFromResource("rulesets/apex/quickstart.xml");
RuleSet ruleset = rulesetLoader().loadFromResource(QUICKSTART_RULESET);
assertNotNull(ruleset);
});
assertTrue(log.isEmpty(), "No Logging expected");
}
@Test
void correctEncoding() throws Exception {
assertTrue(AbstractRuleSetFactoryTest.hasCorrectEncoding(QUICKSTART_RULESET));
}
private RuleSetLoader rulesetLoader() {
return new RuleSetLoader().enableCompatibility(false);
}

2
pmd-html/src/main/resources/category/html/bestpractices.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Best Practices"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-html/src/main/resources/category/html/codestyle.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Code Style"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-html/src/main/resources/category/html/design.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Design"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-html/src/main/resources/category/html/documentation.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Documentation"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-html/src/main/resources/category/html/errorprone.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Error Prone"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-html/src/main/resources/category/html/multithreading.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Multithreading"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-html/src/main/resources/category/html/performance.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Performance"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-html/src/main/resources/category/html/security.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Security"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-java/src/main/resources/category/java/bestpractices.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Best Practices"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-java/src/main/resources/category/java/codestyle.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Code Style"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-java/src/main/resources/category/java/design.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Design"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-java/src/main/resources/category/java/documentation.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Documentation"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-java/src/main/resources/category/java/errorprone.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Error Prone"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-java/src/main/resources/category/java/multithreading.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Multithreading"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-java/src/main/resources/category/java/performance.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Performance"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-java/src/main/resources/category/java/security.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Security" xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

2
pmd-java/src/main/resources/rulesets/java/quickstart.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="quickstart"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

9
pmd-java/src/test/java/net/sourceforge/pmd/lang/java/QuickstartRulesetTest.java
View File

@ -9,20 +9,27 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test;
import net.sourceforge.pmd.AbstractRuleSetFactoryTest;
import net.sourceforge.pmd.RuleSet;
import net.sourceforge.pmd.RuleSetLoader;
import com.github.stefanbirkner.systemlambda.SystemLambda;
class QuickstartRulesetTest {
private static final String QUICKSTART_RULESET = "rulesets/java/quickstart.xml";
@Test
void noDeprecations() throws Exception {
RuleSetLoader ruleSetLoader = new RuleSetLoader().enableCompatibility(false);
String errorOutput = SystemLambda.tapSystemErr(() -> {
RuleSet quickstart = ruleSetLoader.loadFromResource("rulesets/java/quickstart.xml");
RuleSet quickstart = ruleSetLoader.loadFromResource(QUICKSTART_RULESET);
assertFalse(quickstart.getRules().isEmpty());
});
assertTrue(errorOutput.isEmpty());
}
@Test
void correctEncoding() throws Exception {
assertTrue(AbstractRuleSetFactoryTest.hasCorrectEncoding(QUICKSTART_RULESET));
}
}

2
pmd-javascript/src/main/resources/category/ecmascript/bestpractices.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Best Practices"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-javascript/src/main/resources/category/ecmascript/codestyle.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Code Style"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-javascript/src/main/resources/category/ecmascript/design.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Design"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

Some files were not shown because too many files have changed in this diff Show More