phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace Node#apply(List<Node>) with apply(Node)

Browse Source
This commit is contained in:
Clément Fournier
2020-02-15 04:51:23 +01:00
parent f27d5fb5f6
commit 8f13dd82f0
36 changed files with 105 additions and 284 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pmd-javascript/src/main/java/net/sourceforge/pmd/lang/ecmascript/rule/AbstractEcmascriptRule.java
View File

@ -4,8 +4,6 @@
package net.sourceforge.pmd.lang.ecmascript.rule;
import java.util.List;
import net.sourceforge.pmd.RuleContext;
import net.sourceforge.pmd.lang.LanguageRegistry;
import net.sourceforge.pmd.lang.ParserOptions;
@ -40,16 +38,10 @@ public abstract class AbstractEcmascriptRule extends AbstractRule
return new EcmascriptParserOptions(this);
}
@Override
public void apply(List<? extends Node> nodes, RuleContext ctx) {
visitAll(nodes, ctx);
}
protected void visitAll(List<? extends Node> nodes, RuleContext ctx) {
for (Object element : nodes) {
ASTAstRoot node = (ASTAstRoot) element;
visit(node, ctx);
}
@Override
public void apply(Node target, RuleContext ctx) {
((EcmascriptNode<?>) target).jjtAccept(this, ctx);
}
}

3
pmd-javascript/src/test/java/net/sourceforge/pmd/lang/ecmascript/ast/EcmascriptParserTest.java
View File

@ -9,7 +9,6 @@ import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import org.junit.Test;
@ -66,7 +65,7 @@ public class EcmascriptParserTest extends EcmascriptParserTestBase {
MyEcmascriptRule rule = new MyEcmascriptRule();
RuleContext ctx = new RuleContext();
rule.apply(Arrays.asList(js.parse(source)), ctx);
rule.apply(js.parse(source), ctx);
assertEquals("Scope from 2 to 4", output.get(0));
assertEquals("Scope from 4 to 6", output.get(1));