Fixed false negative in UselessOverridingMethod

using < 0 instead of > 0 in getting argument list size. Maybe we should have a rule to detect this...


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6408 51baf565-9d33-0410-a72c-fc3788e3496d

pmd/etc/changelog.txt

@@ -14,6 +14,7 @@ Fixed bug 2056318 - False positive for AvoidInstantiatingObjectsInLoops
 Optimizations and false positive fixes in PreserveStackTrace
 @SuppressWarnings("all") disables all warnings
 All comment types are now stored in ASTCompilationUnit, not just formal ones
+Fixed false negative in UselessOverridingMethod
 
 New rule:
 	Basic ruleset:	EmptyInitializer

pmd/regress/test/net/sourceforge/pmd/rules/basic/xml/UselessOverridingMethod.xml

@@ -229,6 +229,20 @@ public class Foo extends Bar
 public Object clone() throws CloneNotSupportedException {
 	return super.clone();
 }
+}
+     ]]></code>
+    </test-code>
+    <test-code>
+        <description><![CDATA[
+clone method with arguments should not be ignored
+     ]]></description>
+        <expected-problems>1</expected-problems>
+        <code><![CDATA[
+public class Foo extends Bar
+{
+public Object clone(Object o) throws CloneNotSupportedException {
+	return super.clone(o);
+}
 }
      ]]></code>
     </test-code>

pmd/src/net/sourceforge/pmd/rules/UselessOverridingMethod.java

@@ -97,7 +97,7 @@ public class UselessOverridingMethod extends AbstractRule {
 		try
 		{
 			List parameters = node.findChildNodesWithXPath("./MethodDeclarator/FormalParameters/*");
-			if ( parameters != null && parameters.size() < 0 ) {
+			if ( parameters != null && parameters.size() > 0 ) {
 				result = true;
 			}
 		} catch (JaxenException e) {